Skip to content

Add consumer proguard rules #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Add consumer proguard rules #6279

merged 5 commits into from
Sep 26, 2024

Conversation

emilypgoogle
Copy link
Collaborator

No description provided.

@emilypgoogle emilypgoogle requested a review from rlazo September 19, 2024 16:24
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 19, 2024

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Unit Test Results

  16 files   -   24    16 suites   - 24   15s ⏱️ - 1m 13s
107 tests  - 202  107 ✔️  - 202  0 💤 ±0  0 ±0 
214 runs   - 416  214 ✔️  - 416  0 💤 ±0  0 ±0 

Results for commit 8408e26. ± Comparison against base commit 552132b.

This pull request removes 309 and adds 107 tests. Note that renamed tests count towards both.
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance()
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region)
com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists
com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_configWithRolloutMetadata_storedInActivatedCacheSuccessfully
…
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
com.google.firebase.vertexai.StreamingSnapshotTests ‑ malformed content
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 19, 2024

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (552132b)Merge (458a70d)Diff
    aar474 kB472 kB-1.29 kB (-0.3%)
    apk (aggressive)479 kB1.13 MB+655 kB (+136.8%)
    apk (release)9.29 MB9.29 MB-1.72 kB (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b5vLBrFwHN.html

@rlazo
Copy link
Collaborator

rlazo commented Sep 19, 2024

Double check with the quickstart app

https://github.com/firebase/quickstart-android/tree/master/vertexai

adding these to the app/build.gradle.kts fiile of the app

    buildTypes {
        getByName("release") {
            isMinifyEnabled = true
        }

@rlazo rlazo added this to the vertexai-ga milestone Sep 21, 2024
@emilypgoogle emilypgoogle requested a review from rlazo September 25, 2024 20:25
@rlazo rlazo merged commit 885b66f into main Sep 26, 2024
29 of 30 checks passed
@rlazo rlazo deleted the ep/vertex-proguard branch September 26, 2024 17:09
rlazo pushed a commit that referenced this pull request Sep 27, 2024
@firebase firebase locked and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants