Add a bunch of unit test coverage for mutations and queries #6296

dconeybe · 2024-09-23T18:48:05Z

Added MutationRefImplUnitTest.kt, OperationRefImplUnitTest.kt, and QueryRefImplUnitTest.kt, and added more coverage into DataConnectGrpcClientUnitTest.kt

…g MutationRefImplUnitTest.kt, OperationRefImplUnitTest.kt, QueryRefImplUnitTest.kt, and DataConnectGrpcClientUnitTest.kt

google-oss-bot · 2024-09-23T18:48:43Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2024-09-23T19:08:30Z

Size Report ¹

Affected Products

base
Type Base (2f96d94) Merge (f65cf43) Diff
apk (aggressive) ? 8.80 kB ? (?)
apk (release) ? 9.77 kB ? (?)
firebase-abt
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 12.4 kB ? (?)
apk (aggressive) ? 141 kB ? (?)
apk (release) ? 4.41 MB ? (?)
firebase-annotations
Type Base (2f96d94) Merge (f65cf43) Diff
apk (aggressive) ? 8.80 kB ? (?)
apk (release) ? 12.0 kB ? (?)
firebase-appcheck
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 39.2 kB ? (?)
apk (aggressive) ? 390 kB ? (?)
apk (release) ? 4.88 MB ? (?)
firebase-appcheck-debug
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 9.34 kB ? (?)
apk (aggressive) ? 396 kB ? (?)
apk (release) ? 4.89 MB ? (?)
firebase-appcheck-debug-testing
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 5.39 kB ? (?)
apk (aggressive) ? 421 kB ? (?)
apk (release) ? 5.05 MB ? (?)
firebase-appcheck-interop
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.13 kB ? (?)
apk (aggressive) ? 316 kB ? (?)
apk (release) ? 1.84 MB ? (?)
firebase-appcheck-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.52 kB ? (?)
apk (aggressive) ? 390 kB ? (?)
apk (release) ? 4.88 MB ? (?)
firebase-appcheck-playintegrity
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 9.12 kB ? (?)
apk (aggressive) ? 405 kB ? (?)
apk (release) ? 4.93 MB ? (?)
firebase-appdistribution
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 230 kB ? (?)
apk (aggressive) ? 1.08 MB ? (?)
apk (release) ? 7.01 MB ? (?)
firebase-appdistribution-api
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 18.9 kB ? (?)
apk (aggressive) ? 145 kB ? (?)
apk (release) ? 4.42 MB ? (?)
firebase-appdistribution-api-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.58 kB ? (?)
apk (aggressive) ? 145 kB ? (?)
apk (release) ? 4.42 MB ? (?)
firebase-common
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 116 kB ? (?)
apk (aggressive) ? 140 kB ? (?)
apk (release) ? 4.45 MB ? (?)
firebase-common-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.18 kB ? (?)
apk (aggressive) ? 141 kB ? (?)
apk (release) ? 4.45 MB ? (?)
firebase-components
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 45.7 kB ? (?)
apk (aggressive) ? 20.8 kB ? (?)
apk (release) ? 2.06 MB ? (?)
firebase-config
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 108 kB ? (?)
apk (aggressive) ? 211 kB ? (?)
apk (release) ? 4.58 MB ? (?)
firebase-config-interop
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 10.5 kB ? (?)
apk (aggressive) ? 20.8 kB ? (?)
apk (release) ? 2.02 MB ? (?)
firebase-config-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.26 kB ? (?)
apk (aggressive) ? 211 kB ? (?)
apk (release) ? 4.58 MB ? (?)
firebase-crashlytics
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 410 kB ? (?)
apk (aggressive) ? 698 kB ? (?)
apk (release) ? 5.85 MB ? (?)
firebase-crashlytics-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.54 kB ? (?)
apk (aggressive) ? 699 kB ? (?)
apk (release) ? 5.85 MB ? (?)

`firebase-crashlytics-ndk`

Type	Base (`2f96d94`)	Merge (`f65cf43`)	Diff
aar	?	1.65 MB	? (?)
apk (aggressive / arm64-v8a)	?	1.87 MB	? (?)
apk (aggressive / armeabi-v7a)	?	1.34 MB	? (?)
apk (aggressive / x86)	?	1.85 MB	? (?)
apk (aggressive / x86_64)	?	1.91 MB	? (?)
apk (release / arm64-v8a)	?	7.01 MB	? (?)
apk (release / armeabi-v7a)	?	6.49 MB	? (?)
apk (release / x86)	?	6.99 MB	? (?)
apk (release / x86_64)	?	7.06 MB	? (?)

firebase-database
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 542 kB ? (?)
apk (aggressive) ? 390 kB ? (?)
apk (release) ? 5.34 MB ? (?)
firebase-database-collection
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 32.0 kB ? (?)
apk (aggressive) ? 318 kB ? (?)
apk (release) ? 1.86 MB ? (?)
firebase-database-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.24 kB ? (?)
apk (aggressive) ? 391 kB ? (?)
apk (release) ? 5.34 MB ? (?)
firebase-dataconnect
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 665 kB ? (?)
apk (aggressive) ? 520 kB ? (?)
apk (release) ? 11.0 MB ? (?)
firebase-datatransport
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 4.28 kB ? (?)
apk (aggressive) ? 226 kB ? (?)
apk (release) ? 4.62 MB ? (?)
firebase-decoders-json
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 7.85 kB ? (?)
apk (aggressive) ? 9.38 kB ? (?)
apk (release) ? 26.5 kB ? (?)
firebase-dynamic-links
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 62.3 kB ? (?)
apk (aggressive) ? 387 kB ? (?)
apk (release) ? 4.89 MB ? (?)
firebase-dynamic-links-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.61 kB ? (?)
apk (aggressive) ? 391 kB ? (?)
apk (release) ? 4.89 MB ? (?)
firebase-dynamic-module-support
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 4.17 kB ? (?)
apk (aggressive) ? 157 kB ? (?)
apk (release) ? 4.52 MB ? (?)
firebase-encoders
Type Base (2f96d94) Merge (f65cf43) Diff
apk (aggressive) ? 9.38 kB ? (?)
apk (release) ? 27.2 kB ? (?)
firebase-encoders-json
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 11.5 kB ? (?)
apk (aggressive) ? 20.8 kB ? (?)
apk (release) ? 2.01 MB ? (?)
firebase-encoders-proto
Type Base (2f96d94) Merge (f65cf43) Diff
apk (aggressive) ? 9.56 kB ? (?)
apk (release) ? 40.5 kB ? (?)
firebase-encoders-reflective
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 7.97 kB ? (?)
apk (aggressive) ? 9.75 kB ? (?)
apk (release) ? 42.6 kB ? (?)
firebase-firestore
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 1.44 MB ? (?)
apk (aggressive) ? 554 kB ? (?)
apk (release) ? 11.4 MB ? (?)
firebase-firestore-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.23 kB ? (?)
apk (aggressive) ? 554 kB ? (?)
apk (release) ? 11.4 MB ? (?)
firebase-functions
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 65.9 kB ? (?)
apk (aggressive) ? 440 kB ? (?)
apk (release) ? 5.44 MB ? (?)
firebase-functions-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.24 kB ? (?)
apk (aggressive) ? 440 kB ? (?)
apk (release) ? 5.44 MB ? (?)
firebase-inappmessaging
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 460 kB ? (?)
apk (aggressive) ? 1.05 MB ? (?)
apk (release) ? 11.7 MB ? (?)
firebase-inappmessaging-display
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 163 kB ? (?)
apk (aggressive) ? 2.02 MB ? (?)
apk (release) ? 14.0 MB ? (?)
firebase-inappmessaging-display-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.36 kB ? (?)
apk (aggressive) ? 2.02 MB ? (?)
apk (release) ? 14.0 MB ? (?)
firebase-inappmessaging-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.27 kB ? (?)
apk (aggressive) ? 1.05 MB ? (?)
apk (release) ? 11.7 MB ? (?)
firebase-installations
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 57.7 kB ? (?)
apk (aggressive) ? 148 kB ? (?)
apk (release) ? 4.46 MB ? (?)
firebase-installations-interop
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 6.64 kB ? (?)
apk (aggressive) ? 73.1 kB ? (?)
apk (release) ? 1.40 MB ? (?)
firebase-installations-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.20 kB ? (?)
apk (aggressive) ? 148 kB ? (?)
apk (release) ? 4.46 MB ? (?)
firebase-messaging
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 148 kB ? (?)
apk (aggressive) ? 578 kB ? (?)
apk (release) ? 5.30 MB ? (?)
firebase-messaging-directboot
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.20 kB ? (?)
apk (aggressive) ? 578 kB ? (?)
apk (release) ? 5.31 MB ? (?)
firebase-messaging-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.54 kB ? (?)
apk (aggressive) ? 578 kB ? (?)
apk (release) ? 5.31 MB ? (?)
firebase-ml-modeldownloader
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 125 kB ? (?)
apk (aggressive) ? 235 kB ? (?)
apk (release) ? 4.78 MB ? (?)
firebase-ml-modeldownloader-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.60 kB ? (?)
apk (aggressive) ? 235 kB ? (?)
apk (release) ? 4.78 MB ? (?)
firebase-perf
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 315 kB ? (?)
apk (aggressive) ? 1.57 MB ? (?)
apk (release) ? 9.06 MB ? (?)
firebase-perf-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.21 kB ? (?)
apk (aggressive) ? 1.57 MB ? (?)
apk (release) ? 9.06 MB ? (?)
firebase-sessions
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 168 kB ? (?)
apk (aggressive) ? 560 kB ? (?)
apk (release) ? 5.52 MB ? (?)
firebase-storage
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 134 kB ? (?)
apk (aggressive) ? 399 kB ? (?)
apk (release) ? 5.04 MB ? (?)
firebase-storage-ktx
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 3.24 kB ? (?)
apk (aggressive) ? 399 kB ? (?)
apk (release) ? 5.04 MB ? (?)
firebase-vertexai
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 487 kB ? (?)
apk (aggressive) ? 479 kB ? (?)
apk (release) ? 9.30 MB ? (?)
protolite-well-known-types
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 1.01 MB ? (?)
apk (aggressive) ? 134 kB ? (?)
apk (release) ? 1.68 MB ? (?)
transport-api
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 12.1 kB ? (?)
apk (aggressive) ? 9.38 kB ? (?)
apk (release) ? 31.4 kB ? (?)
transport-backend-cct
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 72.9 kB ? (?)
apk (aggressive) ? 97.8 kB ? (?)
apk (release) ? 258 kB ? (?)
transport-runtime
Type Base (2f96d94) Merge (f65cf43) Diff
aar ? 163 kB ? (?)
apk (aggressive) ? 55.7 kB ? (?)
apk (release) ? 193 kB ? (?)

Test Logs

Merge (f65cf43): https://github.com/firebase/firebase-android-sdk/actions/runs/11000510333

https://storage.googleapis.com/firebase-sdk-metric-reports/AZGauYSP92.html

google-oss-bot · 2024-09-23T19:32:19Z

Coverage Report ¹

This report is too large (224,077 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

Merge (f65cf43): https://github.com/firebase/firebase-android-sdk/actions/runs/11000510333

https://storage.googleapis.com/firebase-sdk-metric-reports/ZypWs3vLPb.html

github-actions · 2024-09-23T19:45:33Z

Unit Test Results

  1 018 files +    8   1 018 suites +8 36m 38s ⏱️ -40s
  5 786 tests +  76   5 765 ✔️ +  77 21 💤 ±0 0 ❌ - 1
11 657 runs +152 11 615 ✔️ +153 42 💤 ±0 0 ❌ - 1

Results for commit 98abec9. ± Comparison against base commit 2f96d94.

Add a bunch of unit test coverage for mutations and queries, includin…

98abec9

…g MutationRefImplUnitTest.kt, OperationRefImplUnitTest.kt, QueryRefImplUnitTest.kt, and DataConnectGrpcClientUnitTest.kt

dconeybe self-assigned this Sep 23, 2024

google-oss-bot added the size/XXL label Sep 23, 2024

dconeybe requested review from maneesht, cherylEnkidu and aashishpatil-g September 23, 2024 19:45

aashishpatil-g approved these changes Sep 23, 2024

View reviewed changes

dconeybe merged commit 2b7f8c2 into dataconnect Sep 23, 2024
257 of 258 checks passed

dconeybe deleted the dconeybe/dataconnect/OpUnitTests branch September 23, 2024 20:14

firebase locked and limited conversation to collaborators Oct 24, 2024

Add a bunch of unit test coverage for mutations and queries #6296

Add a bunch of unit test coverage for mutations and queries #6296

Uh oh!

Conversation

dconeybe commented Sep 23, 2024

Uh oh!

google-oss-bot commented Sep 23, 2024

Uh oh!

google-oss-bot commented Sep 23, 2024

Size Report 1

Affected Products

base

firebase-abt

firebase-annotations

firebase-appcheck

firebase-appcheck-debug

firebase-appcheck-debug-testing

firebase-appcheck-interop

firebase-appcheck-ktx

firebase-appcheck-playintegrity

firebase-appdistribution

firebase-appdistribution-api

firebase-appdistribution-api-ktx

firebase-common

firebase-common-ktx

firebase-components

firebase-config

firebase-config-interop

firebase-config-ktx

firebase-crashlytics

firebase-crashlytics-ktx

firebase-crashlytics-ndk

firebase-database

firebase-database-collection

firebase-database-ktx

firebase-dataconnect

firebase-datatransport

firebase-decoders-json

firebase-dynamic-links

firebase-dynamic-links-ktx

firebase-dynamic-module-support

firebase-encoders

firebase-encoders-json

firebase-encoders-proto

firebase-encoders-reflective

firebase-firestore

firebase-firestore-ktx

firebase-functions

firebase-functions-ktx

firebase-inappmessaging

firebase-inappmessaging-display

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations

firebase-installations-interop

firebase-installations-ktx

firebase-messaging

firebase-messaging-directboot

firebase-messaging-ktx

firebase-ml-modeldownloader

firebase-ml-modeldownloader-ktx

firebase-perf

firebase-perf-ktx

firebase-sessions

firebase-storage

firebase-storage-ktx

firebase-vertexai

protolite-well-known-types

transport-api

transport-backend-cct

transport-runtime

Test Logs

Uh oh!

google-oss-bot commented Sep 23, 2024

Coverage Report 1

Test Logs

Uh oh!

github-actions bot commented Sep 23, 2024

Unit Test Results

Uh oh!

Size Report ¹

`base`

`firebase-abt`

`firebase-annotations`

`firebase-appcheck`

`firebase-appcheck-debug`

`firebase-appcheck-debug-testing`

`firebase-appcheck-interop`

`firebase-appcheck-ktx`

`firebase-appcheck-playintegrity`

`firebase-appdistribution`

`firebase-appdistribution-api`

`firebase-appdistribution-api-ktx`

`firebase-common`

`firebase-common-ktx`

`firebase-components`

`firebase-config`

`firebase-config-interop`

`firebase-config-ktx`

`firebase-crashlytics`

`firebase-crashlytics-ktx`

`firebase-crashlytics-ndk`

`firebase-database`

`firebase-database-collection`

`firebase-database-ktx`

`firebase-dataconnect`

`firebase-datatransport`

`firebase-decoders-json`

`firebase-dynamic-links`

`firebase-dynamic-links-ktx`

`firebase-dynamic-module-support`

`firebase-encoders`

`firebase-encoders-json`

`firebase-encoders-proto`

`firebase-encoders-reflective`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-functions`

`firebase-functions-ktx`

`firebase-inappmessaging`

`firebase-inappmessaging-display`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations`

`firebase-installations-interop`

`firebase-installations-ktx`

`firebase-messaging`

`firebase-messaging-directboot`

`firebase-messaging-ktx`

`firebase-ml-modeldownloader`

`firebase-ml-modeldownloader-ktx`

`firebase-perf`

`firebase-perf-ktx`

`firebase-sessions`

`firebase-storage`

`firebase-storage-ktx`

`firebase-vertexai`

`protolite-well-known-types`

`transport-api`

`transport-backend-cct`

`transport-runtime`

Coverage Report ¹