Skip to content

Add SerializersModule support to QueryRef and MutationRef #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 23, 2024

Although an advanced feature, some direct users of the Data Connect Core SDK may want to use special serializers that require specifying a custom SerializersModule. This PR adds the ability to do just that.

@dconeybe dconeybe self-assigned this Sep 23, 2024
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (2b7f8c2) to 10.44% (5c23110) by ?.

    47 individual files with coverage change

    FilenameBase (2b7f8c2)Merge (5c23110)Diff
    AnyValue.kt?0.00%?
    AnyValueSerializer.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?0.00%?
    DataConnectAuth.kt?0.00%?
    DataConnectCredentialsTokenManager.kt?0.00%?
    DataConnectError.kt?0.00%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    DateSerializer.kt?0.00%?
    FirebaseDataConnect.kt?50.00%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?38.05%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    Logger.kt?52.17%?
    LogLevel.kt?100.00%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?12.09%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?20.51%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?20.41%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    TimestampSerializer.kt?0.00%?
    Util.kt?6.56%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MHCKI3DekQ.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (2b7f8c2)Merge (5c23110)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-dataconnect

    TypeBase (2b7f8c2)Merge (5c23110)Diff
    aar?680 kB? (?)
    apk (aggressive)?520 kB? (?)
    apk (release)?11.0 MB? (?)
  • protolite-well-known-types

    TypeBase (2b7f8c2)Merge (5c23110)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rTwH7j7FS2.html

Copy link
Contributor

Unit Test Results

  48 files   -      948    48 suites   - 948   1m 25s ⏱️ - 34m 19s
483 tests  -   5 303  483 ✔️  -   5 281  0 💤  - 21  0  - 1 
966 runs   - 10 362  966 ✔️  - 10 319  0 💤  - 42  0  - 1 

Results for commit 11b2a48. ± Comparison against base commit 2b7f8c2.

@dconeybe dconeybe merged commit 9f3210a into dataconnect Sep 23, 2024
34 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/SerializersModule branch September 23, 2024 22:57
@firebase firebase locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants