Skip to content

Create the function declaration schema at construction time #6302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 24, 2024

By creating the schema earlier, any errors when declaring the schema will be caught at the declaration site, which makes debugging much easier.

By creating the schema earlier, any errors when declaring the schema
will be caught at the declaration site, which makes debugging much easier.
Copy link
Contributor

github-actions bot commented Sep 24, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2024

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Unit Test Results

  16 files   -    274    16 suites   - 274   16s ⏱️ - 8m 17s
107 tests  - 1 755  107 ✔️  - 1 738  0 💤  - 17  0 ±0 
214 runs   - 3 550  214 ✔️  - 3 516  0 💤  - 34  0 ±0 

Results for commit 5b2494f. ± Comparison against base commit fe9d619.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (fe9d619)Merge (7f05293)Diff
    aar464 kB464 kB+3 B (+0.0%)
    apk (release)9.29 MB9.29 MB+60 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/i3DV22sZe9.html

@rlazo rlazo merged commit 2f851c7 into main Sep 24, 2024
28 of 30 checks passed
@rlazo rlazo deleted the rl.function.declaration.early branch September 24, 2024 18:31
@rlazo rlazo added this to the vertexai-ga milestone Oct 3, 2024
@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants