Skip to content

dataconnect: fix gradle plugin to gracefully handle schemaExtensionsOutputEnabled not being explicitly specified #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dconeybe
Copy link
Contributor

The schemaExtensionsOutputEnabled knob of the Data Connect gradle plugin was always meant to be optional; however, it was accidentally made to be required, resulting in the following unnecessary error if it was not explicitly specified:

A problem was found with the configuration of task ':firebase-dataconnect:connectors:runDebugDataConnectEmulator' (type 'DataConnectRunEmulatorTask').
  - In plugin 'com.google.firebase.dataconnect.gradle.plugin.DataConnectGradlePlugin$Inject' type 'com.google.firebase.dataconnect.gradle.plugin.DataConnectRunEmulatorTask' property 'schemaExtensionsOutputEnabled' doesn't have a configured value.
    
    Reason: This property isn't marked as optional and no value has been configured.
    
    Possible solutions:
      1. Assign a value to 'schemaExtensionsOutputEnabled'.
      2. Mark property 'schemaExtensionsOutputEnabled' as optional.

This PR correctly makes it optional, defaulting to false.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe merged commit 46f2fd0 into main Sep 30, 2024
38 of 40 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/SchemaExtensionsOutputEnabledOptional branch September 30, 2024 17:05
@firebase firebase locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants