Skip to content

dataconnect: improve gradle plugin errors when the version of the cli is not found #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 1, 2024

If a version of the Data Connect CLI is not found, then the error message produced by the Data Connect gradle plugin is not very helpful. This PR changes the error message to list the versions that are available, and also print JSON blob that can be copied and pasted into DataConnectExecutableVersions.json so that the version is no longer "unknown".

Copy link
Contributor

github-actions bot commented Oct 1, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
Copy link
Contributor

github-actions bot commented Oct 1, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Unit Test Results

  48 files   -      970    48 suites   - 970   1m 21s ⏱️ - 35m 34s
484 tests  -   5 326  484 ✔️  -   5 305  0 💤  - 21  0 ±0 
968 runs   - 10 737  968 ✔️  - 10 695  0 💤  - 42  0 ±0 

Results for commit cffa8de. ± Comparison against base commit 834f27f.

♻️ This comment has been updated with latest results.

@dconeybe dconeybe marked this pull request as ready for review October 1, 2024 03:57
@dconeybe dconeybe merged commit bb5a4d4 into main Oct 1, 2024
37 checks passed
@dconeybe dconeybe deleted the dconeybe/GradlePluginImproveVersionNotFoundError branch October 1, 2024 16:18
@firebase firebase locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants