Skip to content

Bump protobuf to 3.25.5 #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 10, 2024
3 changes: 0 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ ext {
robolectricVersion = libs.versions.robolectric.get()
androidxTestCoreVersion = libs.versions.androidx.test.core.get()
androidxTestJUnitVersion = libs.versions.androidx.test.junit.get()
protocVersion = libs.versions.protoc.get()
javaliteVersion = libs.versions.javalite.get()
protobufJavaUtilVersion = libs.versions.protobufjavautil.get()
}

apply plugin: com.google.firebase.gradle.plugins.PublishingPlugin
Expand Down
3 changes: 2 additions & 1 deletion encoders/firebase-encoders-proto/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Unreleased

* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ java {

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
}

Expand All @@ -47,7 +47,7 @@ dependencies {
testAnnotationProcessor project(':encoders:firebase-encoders-processor')

testImplementation 'com.google.guava:guava:31.0-jre'
testImplementation "com.google.protobuf:protobuf-java-util:$protobufJavaUtilVersion"
testImplementation libs.protobuf.java.util
testImplementation "com.google.truth:truth:$googleTruthVersion"
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'
testImplementation 'junit:junit:4.13.1'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ plugins {

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
}

Expand Down
4 changes: 2 additions & 2 deletions encoders/protoc-gen-firebase-encoders/tests/tests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies {

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
plugins {
firebaseEncoders {
Expand All @@ -51,7 +51,7 @@ dependencies {

testImplementation project(":encoders:firebase-encoders")
testImplementation project(":encoders:firebase-encoders-proto")
testImplementation "com.google.protobuf:protobuf-java:3.21.9"
testImplementation libs.protobuf.java
testImplementation "com.google.truth:truth:1.0.1"
testImplementation 'junit:junit:4.13.1'
}
3 changes: 2 additions & 1 deletion firebase-config/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased

* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

# 22.0.0
* [changed] Bump internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion firebase-crashlytics-ndk/firebase-crashlytics-ndk.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ dependencies {

androidTestImplementation "androidx.test:core:$androidxTestCoreVersion"
androidTestImplementation 'androidx.test:runner:1.4.0'
androidTestImplementation "com.google.protobuf:protobuf-javalite:$javaliteVersion"
androidTestImplementation libs.protobuf.java.lite
androidTestImplementation 'com.linkedin.dexmaker:dexmaker:2.28.1'
androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:2.28.1'
androidTestImplementation 'org.mockito:mockito-core:3.4.3'
Expand Down
3 changes: 3 additions & 0 deletions firebase-crashlytics/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Unreleased
* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).


# 19.2.0
* [fixed] Improved data consistency for rapid user actions.
Expand Down
2 changes: 1 addition & 1 deletion firebase-crashlytics/firebase-crashlytics.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ dependencies {
androidTestImplementation(libs.androidx.test.runner)
androidTestImplementation(libs.androidx.test.junit)
androidTestImplementation("com.google.firebase:firebase-encoders-json:18.0.1")
androidTestImplementation("com.google.protobuf:protobuf-java:3.21.11")
androidTestImplementation(libs.protobuf.java)
androidTestImplementation(libs.truth)
androidTestImplementation("com.linkedin.dexmaker:dexmaker:2.28.3")
androidTestImplementation(libs.mockito.dexmaker)
Expand Down
3 changes: 3 additions & 0 deletions firebase-dataconnect/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Unreleased
* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

# 16.0.0-beta01
* [feature] Initial release of the Data Connect SDK (public preview). Learn how to
Expand All @@ -19,3 +21,4 @@
([#6299](https://github.com/firebase/firebase-android-sdk/pull/6299))
* [changed] Added `equals` and `hashCode` methods to `GeneratedConnector`.
([#6177](https://github.com/firebase/firebase-android-sdk/pull/6177))

3 changes: 2 additions & 1 deletion firebase-firestore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased

* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

# 25.1.0
* [feature] Add support for the VectorValue type. [#6154](//github.com/firebase/firebase-android-sdk/pull/6154)
Expand Down
4 changes: 2 additions & 2 deletions firebase-firestore/firebase-firestore.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ protobuf {
// Configure the protoc executable
protoc {
// Download from repositories
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
plugins {
grpc {
Expand Down Expand Up @@ -164,7 +164,7 @@ dependencies {
testImplementation 'org.mockito:mockito-core:2.25.0'
testImplementation "org.robolectric:robolectric:$robolectricVersion"

testCompileOnly "com.google.protobuf:protobuf-java:$protocVersion"
testCompileOnly libs.protobuf.java

androidTestImplementation "androidx.annotation:annotation:1.1.0"
androidTestImplementation 'androidx.test:rules:1.5.0'
Expand Down
2 changes: 1 addition & 1 deletion firebase-firestore/ktx/ktx.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,5 @@ dependencies {
testImplementation 'org.mockito:mockito-core:2.25.0'
testImplementation "org.robolectric:robolectric:$robolectricVersion"

testCompileOnly "com.google.protobuf:protobuf-java:$protocVersion"
testCompileOnly libs.protobuf.java
}
3 changes: 2 additions & 1 deletion firebase-inappmessaging-display/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased

* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

# 21.0.0
* [fixed] Fixed bad token exception while showing FIAM
Expand Down
3 changes: 2 additions & 1 deletion firebase-inappmessaging/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased

* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

# 21.0.0
* [fixed] Fixed bad token exception while showing FIAM
Expand Down
2 changes: 1 addition & 1 deletion firebase-inappmessaging/firebase-inappmessaging.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ protobuf {
// Configure the protoc executable
protoc {
// Download from repositories
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
plugins {
grpc {
Expand Down
3 changes: 3 additions & 0 deletions firebase-messaging/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# Unreleased
* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).


# 24.0.2
* [changed] Included message priority when logging to Firelog.
Expand Down
2 changes: 1 addition & 1 deletion firebase-messaging/firebase-messaging.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ protobuf {
protobuild project(path: ':encoders:protoc-gen-firebase-encoders', configuration: 'shadow')
}
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
plugins {
firebaseEncoders {
Expand Down
2 changes: 2 additions & 0 deletions firebase-ml-modeldownloader/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Unreleased
* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).


# 25.0.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ protobuf {
// Configure the protoc executable
protoc {
// Download from repositories
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
generateProtoTasks {
all().each { task ->
Expand Down Expand Up @@ -121,7 +121,7 @@ dependencies {
testImplementation 'androidx.test:runner:1.5.1'
testImplementation "androidx.test.ext:junit:$androidxTestJUnitVersion"
testImplementation 'com.github.tomakehurst:wiremock-standalone:2.26.3'
testImplementation "com.google.protobuf:protobuf-java-util:$protobufJavaUtilVersion"
testImplementation libs.protobuf.java.util
testImplementation "com.google.truth:truth:$googleTruthVersion"
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'
testImplementation 'junit:junit:4.13-beta-2'
Expand Down
3 changes: 2 additions & 1 deletion firebase-perf/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased

* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

# 21.0.1
* [fixed] Fixed an `ExceptionInInitializerError` where the `url.openStream()` causes a crash if
Expand Down
6 changes: 3 additions & 3 deletions firebase-perf/firebase-perf.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ firebaseLibrary {

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
generateProtoTasks {
all().each { task ->
Expand Down Expand Up @@ -104,7 +104,7 @@ dependencies {
implementation "androidx.annotation:annotation:1.1.0"
implementation "androidx.lifecycle:lifecycle-process:2.3.1"
implementation "com.google.android.gms:play-services-tasks:18.0.1"
implementation "com.google.protobuf:protobuf-javalite:$javaliteVersion"
implementation libs.protobuf.java.lite
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
implementation 'androidx.annotation:annotation:1.7.0'
implementation 'androidx.appcompat:appcompat:1.2.0'
Expand All @@ -130,7 +130,7 @@ dependencies {
exclude group: 'com.google.firebase', module: 'firebase-common'
exclude group: 'com.google.firebase', module: 'firebase-components'
}
testCompileOnly "com.google.protobuf:protobuf-java:3.21.9"
testCompileOnly libs.protobuf.java
testImplementation "androidx.test:core:$androidxTestCoreVersion"
testImplementation "com.google.truth:truth:$googleTruthVersion"
testImplementation "org.robolectric:robolectric:$robolectricVersion"
Expand Down
2 changes: 1 addition & 1 deletion firebase-perf/ktx/ktx.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ dependencies {
testImplementation 'org.mockito:mockito-core:2.25.0'
testImplementation "org.robolectric:robolectric:$robolectricVersion"

testCompileOnly "com.google.protobuf:protobuf-java:3.21.9"
testCompileOnly libs.protobuf.java
}
6 changes: 3 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ coroutines = "1.7.3"
dagger = "2.43.2"
grpc = "1.62.2"
grpcKotlin = "1.4.1"
javalite = "3.21.11"
javalite = "3.25.5"
kotlin = "1.8.22"
mockk = "1.13.11"
serialization-plugin = "1.8.22"
protoc = "3.21.11"
protoc = "3.25.5"
truth = "1.4.2"
robolectric = "4.12"
protobufjavautil = "3.21.11"
protobufjavautil = "3.25.5"
kotest = "5.9.0" # Do not use 5.9.1 because it reverts the fix for https://github.com/kotest/kotest/issues/3981
quickcheck = "0.6"
serialization = "1.5.1"
Expand Down
4 changes: 2 additions & 2 deletions protolite-well-known-types/protolite-well-known-types.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ firebaseLibrary {

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = "com.google.protobuf:protoc:3.21.11"
}
generateProtoTasks {
all().each { task ->
Expand Down Expand Up @@ -68,5 +68,5 @@ dependencies {
exclude group: "com.google.protobuf", module: "protobuf-java"
}

implementation "com.google.protobuf:protobuf-javalite:$javaliteVersion"
implementation "com.google.protobuf:protobuf-javalite:3.21.11"
}
2 changes: 2 additions & 0 deletions transport/transport-backend-cct/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Unreleased
* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).


# 3.3.0
Expand Down
4 changes: 2 additions & 2 deletions transport/transport-backend-cct/transport-backend-cct.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ protobuf {
// Configure the protoc executable
protoc {
// Download from repositories
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
generateProtoTasks {
all().each { task ->
Expand Down Expand Up @@ -71,7 +71,7 @@ dependencies {

testImplementation "androidx.test:core:$androidxTestCoreVersion"
testImplementation 'com.github.tomakehurst:wiremock:3.0.1'
testImplementation "com.google.protobuf:protobuf-java-util:$protobufJavaUtilVersion"
testImplementation libs.protobuf.java.util
testImplementation "com.google.truth:truth:$googleTruthVersion"
testImplementation 'com.google.truth.extensions:truth-proto-extension:1.0'
testImplementation 'junit:junit:4.13.1'
Expand Down
2 changes: 2 additions & 0 deletions transport/transport-runtime/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Unreleased
* [changed] Updated protobuf dependency to `3.25.5` to fix
[CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).


# 3.3.0
Expand Down
2 changes: 1 addition & 1 deletion transport/transport-runtime/transport-runtime.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies {

protobuf {
protoc {
artifact = "com.google.protobuf:protoc:$protocVersion"
artifact = libs.protoc.get().toString()
}
plugins {
firebaseEncoders {
Expand Down
Loading