Skip to content

M154 mergeback #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

M154 mergeback #6345

merged 2 commits into from
Oct 4, 2024

Conversation

emilypgoogle
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-crashlytics-ndk
firebase-crashlytics
firebase-dataconnect
firebase-messaging-directboot
firebase-messaging
firebase-sessions
firebase-storage

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Unit Test Results

   194 files   -    824     194 suites   - 824   14m 48s ⏱️ - 22m 15s
1 196 tests  - 4 609  1 195 ✔️  - 4 588  1 💤  - 21  0 ❌ ±0 
2 418 runs   - 9 277  2 416 ✔️  - 9 235  2 💤  - 42  0 ❌ ±0 

Results for commit 729f045. ± Comparison against base commit 7083c1d.

@emilypgoogle emilypgoogle requested a review from rlazo October 3, 2024 19:17
rlazo
rlazo requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one missing change is the last released version for vertex (but not the next, as that one has already been bumped in a different RP). Please update that file

@emilypgoogle emilypgoogle requested a review from rlazo October 3, 2024 19:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Test Results

  210 files    210 suites   15m 2s ⏱️
1 304 tests 1 303 ✅ 1 💤 0 ❌
2 634 runs  2 632 ✅ 2 💤 0 ❌

Results for commit 3d6e7d9.

@emilypgoogle emilypgoogle merged commit f761b2c into main Oct 4, 2024
74 of 75 checks passed
@emilypgoogle emilypgoogle deleted the m154-mergeback branch October 4, 2024 15:12
@firebase firebase locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilypgoogle @rlazo @google-oss-bot