Fix inappmessaging-display sdk size issues. #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code removed correspond to a wrong version of inappmessaging.
allisonbm92
reviewed
Jul 18, 2019
tools/measurement/apksize/src/inappmessagingdisplay/inappmessaging-display.gradle
Show resolved
Hide resolved
|
/test build-plugins-check |
allisonbm92
reviewed
Jul 18, 2019
|
|
||
| public class InAppMessagingDisplay implements SampleCode { | ||
|
|
||
| public class MyClickListener implements FirebaseInAppMessagingClickListener { |
There was a problem hiding this comment.
Do you want to remove all of this? I think leaving this will make the test more equitable compared to the others.
There was a problem hiding this comment.
I've update the test code to be more comparable with the others. PTAL.
allisonbm92
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.