-
Notifications
You must be signed in to change notification settings - Fork 625
dataconnect: fix build on macos and windows #6350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataconnect: fix build on macos and windows #6350
Conversation
Release note changesNo release note changes were detected. If you made changes that should be |
Test Results 48 files - 959 48 suites - 959 1m 34s ⏱️ - 34m 42s Results for commit 6ad30db. ± Comparison against base commit 57e64e7. This pull request removes 5331 tests.
♻️ This comment has been updated with latest results. |
Without this fix, the command
would only succeed on Linux; on macOS it would give an error like
or
This was because the gradle plugin for data connect was always downloading the linux binary. This PR fixes it to download the windows, macos, or linux binary, as appropriate for the host OS.