Skip to content

dataconnect: DataConnectBackendUnitTest.kt modernized #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 7, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

2 similar comments
Copy link
Contributor

github-actions bot commented Oct 7, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Test Results

 48 files   -    959   48 suites   - 959   1m 29s ⏱️ - 34m 47s
478 tests  -  5 331  477 ✅  -  5 309  1 💤  - 21  0 ❌  - 1 
956 runs   - 10 594  954 ✅  - 10 551  2 💤  - 42  0 ❌  - 1 

Results for commit 40a7fdc. ± Comparison against base commit 57e64e7.

This pull request removes 5332 and adds 1 tests. Note that renamed tests count towards both.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…
com.google.firebase.dataconnect.testutil.DataConnectBackendUnitTest ‑ fromInstrumentationArgument(null) should return null

♻️ This comment has been updated with latest results.

@dconeybe dconeybe marked this pull request as ready for review October 7, 2024 18:28
@dconeybe dconeybe merged commit 3f3b688 into main Oct 8, 2024
35 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/TestModernization4 branch October 8, 2024 18:26
@firebase firebase locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants