-
Notifications
You must be signed in to change notification settings - Fork 620
Deprecate additional FCM upstream messaging methods. #6411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,15 +40,10 @@ | |
/** | ||
* A remote Firebase Message. | ||
* | ||
* <p>Messages will be received via {@link | ||
* FirebaseMessagingService#onMessageReceived(RemoteMessage)} and can be sent via {@link | ||
* FirebaseMessaging#send(RemoteMessage)}. | ||
* <p>Messages will be received via {@link FirebaseMessagingService#onMessageReceived(RemoteMessage)}. | ||
* | ||
* <p>Messages may have a {@link Notification} instance if they are received while the application | ||
* is in the foreground, otherwise they will be automatically posted to the notification tray. | ||
* | ||
* <p>Use the {@link Builder} class for building message instances to send via {@link | ||
* FirebaseMessaging#send(RemoteMessage)}. | ||
*/ | ||
@SafeParcelable.Reserved({1 /* version field removed by bot go/versionless-safeparcelable */}) | ||
@SafeParcelable.Class(creator = "RemoteMessageCreator") | ||
|
@@ -115,11 +110,11 @@ public String getFrom() { | |
/** | ||
* Gets the message destination. | ||
* | ||
* <ul> | ||
* <li>For upstream messages, this will be of the form {@code [email protected]}. | ||
* <li>For downstream messages, this will be the Firebase installations ID (FID). | ||
* </ul> | ||
* @deprecated FCM upstream messaging is decommissioned. Learn more in the | ||
* <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features | ||
* deprecated in June 2023</a>. | ||
*/ | ||
@Deprecated | ||
@Nullable | ||
public String getTo() { | ||
return bundle.getString(MessagePayloadKeys.TO); | ||
|
@@ -373,13 +368,13 @@ public String getMessageType() { | |
/** @hide */ | ||
@Nullable | ||
public String getCollapseKey() { | ||
return bundle.getString(MessagePayloadKeys.MESSAGE_TYPE); | ||
return bundle.getString(MessagePayloadKeys.COLLAPSE_KEY); | ||
} | ||
|
||
/** @hide */ | ||
@IntRange(from = 0, to = 86400) | ||
public int getTtl() { | ||
return Integer.parseInt(bundle.getString(MessagePayloadKeys.MESSAGE_TYPE, "0")); | ||
return Integer.parseInt(bundle.getString(MessagePayloadKeys.TTL, "0")); | ||
} | ||
|
||
/** @hide */ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.