Skip to content

libs.versions.toml: add ThreeTenAbp (backport of java.time for Android) #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

libs.versions.toml: add ThreeTenAbp (backport of java.time for Android) #6416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a70dc
libs.versions.toml: add ThreeTenAbp (backport of java.time for Android)
dconeybe Oct 29, 2024
76087bf
add testing prefix
dconeybe Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions firebase-dataconnect/connectors/connectors.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ dependencies {

testImplementation(project(":firebase-dataconnect:testutil"))
testImplementation(libs.androidx.test.junit)
testImplementation(libs.kotest.assertions)
testImplementation(libs.kotest.property)
testImplementation(libs.kotlin.coroutines.test)
testImplementation(libs.mockk)
testImplementation(libs.robolectric)
Expand All @@ -84,6 +86,7 @@ dependencies {
androidTestImplementation(libs.kotest.assertions)
androidTestImplementation(libs.kotest.property)
androidTestImplementation(libs.kotlin.coroutines.test)
androidTestImplementation(libs.testonly.three.ten.abp)
androidTestImplementation(libs.truth)
androidTestImplementation(libs.truth.liteproto.extension)
androidTestImplementation(libs.turbine)
Expand Down
2 changes: 2 additions & 0 deletions firebase-dataconnect/testutil/testutil.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,15 @@ dependencies {
implementation("com.google.firebase:firebase-auth:22.3.1")

implementation(libs.androidx.test.junit)
implementation(libs.kotest.assertions)
implementation(libs.kotest.property)
implementation(libs.kotlin.coroutines.test)
implementation(libs.kotlinx.coroutines.core)
implementation(libs.kotlinx.serialization.core)
implementation(libs.mockk)
implementation(libs.protobuf.java.lite)
implementation(libs.robolectric)
implementation(libs.testonly.three.ten.abp)
implementation(libs.truth)
}

Expand Down
6 changes: 6 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ quickcheck = { module = "net.java:quickcheck", version.ref = "quickcheck" }
spotless-plugin-gradle = { module = "com.diffplug.spotless:spotless-plugin-gradle", version.ref = "spotless" }
turbine = { module = "app.cash.turbine:turbine", version = "1.0.0" }

# Remove three-ten-abp once minSdkVersion is changed to 26 or later, and, instead use the
# correspondingly-named classes from the java.time package, which should be drop-in replacements.
# Do not use three-ten-abp in production code (it's only for tests) because it has performance
# issues.
testonly-three-ten-abp = { module = "com.jakewharton.threetenabp:threetenabp", version = "1.4.7" }

[bundles]
kotest = ["kotest-runner", "kotest-assertions", "kotest-property", "kotest-property-arbs"]
playservices = ["playservices-base", "playservices-basement", "playservices-tasks"]
Expand Down
Loading