Skip to content

libs.versions.toml: add kotlinx-datetime #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

libs.versions.toml: add kotlinx-datetime #6425

merged 1 commit into from
Nov 1, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 1, 2024

Add "kotlinx.datetime" to libs.versions.toml. Although this PR does not contain any actual uses of the library, a follow-up PR will use it, and I wanted to separate the global change of modifying libs.versions.toml from the code that makes use of it because changing libs.versions.toml has a project-wide blast radius.

See https://github.com/Kotlin/kotlinx-datetime and https://kotlinlang.org/api/kotlinx-datetime/ for more details about the kotlinx.datetime library.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Test Results

 1 022 files  + 1 002   1 022 suites  +1 002   36m 14s ⏱️ + 35m 59s
 5 809 tests + 5 697   5 787 ✅ + 5 675  22 💤 +22  0 ❌ ±0 
11 703 runs  +11 479  11 659 ✅ +11 435  44 💤 +44  0 ❌ ±0 

Results for commit 19b6286. ± Comparison against base commit 22ace25.

@dconeybe dconeybe requested review from rlazo and daymxn November 1, 2024 20:29
@dconeybe dconeybe merged commit e3ad5d7 into main Nov 1, 2024
262 of 264 checks passed
@dconeybe dconeybe deleted the KotlinxDatetime branch November 1, 2024 21:03
@firebase firebase locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants