Skip to content

dataconnect: connectors.gradle.kts: fix unwarranted error from updateJson task during configure time #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 1, 2024

The updateJson custom task in firebase-dataconnect/connectors/connectors.gradle.kts would unnecessarily throw an exception if neither the version nor versions property was specified. This was fine if explicitly invoking the task; however, the task would fail to configure if it is merely being created but not executed, such as when running ./gradlew :firebase-dataconnect:connectors:tasks:

Execution failed for task ':firebase-dataconnect:connectors:tasks'.
> Could not create task ':firebase-dataconnect:connectors:updateJson'.
   > bm6d5ezxzd 'version' or 'versions' property must be specified

This PR downgrades the error to a warning, and only emits the warning when the task is executed. The other properties that get interrogated by the updateJson task were also improved to emit warnings if omitted, assisting with devx when a person is unsure of the command-line arguments recognized by the task.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Test Results

 46 files  + 26   46 suites  +26   1m 26s ⏱️ + 1m 11s
463 tests +351  462 ✅ +350  1 💤 +1  0 ❌ ±0 
926 runs  +702  924 ✅ +700  2 💤 +2  0 ❌ ±0 

Results for commit 4c5b352. ± Comparison against base commit 22ace25.

This pull request removes 112 and adds 463 tests. Note that renamed tests count towards both.
com.google.firebase.vertexai.GenerativeModelTesting ‑ addition
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
…
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…

♻️ This comment has been updated with latest results.

@dconeybe dconeybe merged commit 7542831 into main Nov 1, 2024
30 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/UpdateJsonConfigureExceptionFix branch November 1, 2024 22:29
@firebase firebase locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants