Skip to content

Add missing experimentalApi annotations to vertex tests #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 28, 2024

This reduces the noise we are seeing in our builds

This reduces the noise we are seeing in our builds
@rlazo rlazo requested a review from VinayGuthal November 28, 2024 20:00
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2024

Coverage Report 1

Affected Products

No changes between base commit (bae6706) and merge commit (3f30ba0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mpenaKmrLC.html

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Test Results

 20 files  ±  0   20 suites  ±0   12s ⏱️ -12s
113 tests + 90  113 ✅ + 90  0 💤 ±0  0 ❌ ±0 
226 runs  +158  226 ✅ +158  0 💤 ±0  0 ❌ ±0 

Results for commit 289687a. ± Comparison against base commit bae6706.

This pull request removes 23 and adds 113 tests. Note that renamed tests count towards both.
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2024

Size Report 1

Affected Products

  • base

    TypeBase (bae6706)Merge (3f30ba0)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-vertexai

    TypeBase (bae6706)Merge (3f30ba0)Diff
    aar?477 kB? (?)
    apk (aggressive)?1.14 MB? (?)
    apk (release)?9.29 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jhjKvBtHaW.html

@rlazo rlazo enabled auto-merge (squash) November 29, 2024 01:52
@rlazo rlazo merged commit 800bc7a into main Nov 29, 2024
29 of 30 checks passed
@rlazo rlazo deleted the rl.vertex.tests.api.warn branch November 29, 2024 17:01
@firebase firebase locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants