Skip to content

Address warning in FirebaseAppGetDetector #6542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Address warning in FirebaseAppGetDetector #6542

merged 3 commits into from
Nov 29, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 28, 2024

The override for visitMethodCall was using a different name for the UCallExpression which could cause an issue if called by name

The override for `visitMethodCall` was using a different name for the
`UCallExpression` which could cause an issue if called by name
@rlazo rlazo requested a review from VinayGuthal November 28, 2024 20:00
Copy link
Contributor

github-actions bot commented Nov 28, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2024

Coverage Report 1

Affected Products

No changes between base commit (bae6706) and merge commit (2b40679).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Kx5pE281R6.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 28, 2024

Size Report 1

Affected Products

No changes between base commit (bae6706) and merge commit (2b40679).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IsthtPdN8B.html

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Test Results

 1 008 files  +   988   1 008 suites  +988   32m 20s ⏱️ + 31m 56s
 5 714 tests + 5 691   5 692 ✅ + 5 669  22 💤 +22  0 ❌ ±0 
11 572 runs  +11 504  11 528 ✅ +11 460  44 💤 +44  0 ❌ ±0 

Results for commit 885ccf8. ± Comparison against base commit bae6706.

♻️ This comment has been updated with latest results.

@rlazo rlazo enabled auto-merge (squash) November 29, 2024 01:52
@rlazo rlazo merged commit feeb6a9 into main Nov 29, 2024
195 of 197 checks passed
@rlazo rlazo deleted the rl.app.get.detector branch November 29, 2024 17:01
@firebase firebase locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants