Address Functions compiler warnings #6544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements include: - Make overriden arguments have the same name as the original ones - Inline variable declarations - Remove unused lambda bodies
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/Serializer.html 2024-11-29 14:57:31.411067285 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/Serializer.html 2024-11-29 14:54:56.807108588 +0000
@@ -68,7 +68,7 @@
<tr>
<td><code>final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> obj)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> obj)</code></div>
</td>
</tr>
<tr>
@@ -91,7 +91,7 @@
<h2>Public methods</h2>
<div class="api-item"><a name="decode-kotlin.Any-"></a><a name="decode"></a>
<h3 class="api-name" id="decode(kotlin.Any)">decode</h3>
- <pre class="api-signature no-pretty-print">public final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> obj)</pre>
+ <pre class="api-signature no-pretty-print">public final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> obj)</pre>
</div>
<div class="api-item"><a name="encode-kotlin.Any-"></a><a name="encode"></a>
<h3 class="api-name" id="encode(kotlin.Any)">encode</h3>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/Serializer.html 2024-11-29 14:57:31.379067293 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/Serializer.html 2024-11-29 14:54:56.803108588 +0000
@@ -48,7 +48,7 @@
<tr>
<td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(obj: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(obj: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?)</code></div>
</td>
</tr>
<tr>
@@ -71,7 +71,7 @@
<h2>Public functions</h2>
<div class="api-item"><a name="decode-kotlin.Any-"></a><a name="decode"></a>
<h3 class="api-name" id="decode(kotlin.Any)">decode</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(obj: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/functions/Serializer.html#decode(kotlin.Any)">decode</a>(obj: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
</div>
<div class="api-item"><a name="encode-kotlin.Any-"></a><a name="encode"></a>
<h3 class="api-name" id="encode(kotlin.Any)">encode</h3> |
Vertex AI Mock Responses Check
|
Coverage Report 1Affected Products
Test Logs |
Test Results20 files +12 20 suites +12 24s ⏱️ +5s Results for commit 8317dc0. ± Comparison against base commit 0743d5a. This pull request removes 22 and adds 23 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
VinayGuthal
approved these changes
Nov 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements include: