Skip to content

Remove unneeded package declaration in transport runtime #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2024
Merged

Remove unneeded package declaration in transport runtime #6545

merged 2 commits into from
Nov 29, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 29, 2024

The package declaration inside AndroidManifest.xml is no longer used, and the namespace declaration in the gradle file is the one that should be used.

@rlazo
Remove unneeded package declaration in transport runtime
5111499 
The package declaration inside AndroidManifest.xml is no longer used,
and the `namespace` declaration in the gradle file is the one that
should be used.
@rlazo rlazo requested a review from VinayGuthal November 29, 2024 16:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 29, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • transport-runtime

    Overall coverage changed from ? (bae6706) to 59.71% (9da1dce) by ?.

    93 individual files with coverage change

    FilenameBase (bae6706)Merge (9da1dce)Diff
    AlarmManagerScheduler.java?90.91%?
    AlarmManagerSchedulerBroadcastReceiver.java?6.25%?
    AutoProtoEncoderDoNotUseEncoder.java?84.47%?
    AutoValue_BackendRequest.java?60.00%?
    AutoValue_BackendResponse.java?31.82%?
    AutoValue_CreationContext.java?55.26%?
    AutoValue_EventInternal.java?66.06%?
    AutoValue_EventStoreConfig.java?56.06%?
    AutoValue_PersistedEvent.java?55.17%?
    AutoValue_SchedulerConfig.java?33.33%?
    AutoValue_SchedulerConfig_ConfigValue.java?53.19%?
    AutoValue_SendRequest.java?63.38%?
    AutoValue_TransportContext.java?86.36%?
    BackendFactory.java?0.00%?
    BackendRegistry.java?0.00%?
    BackendRegistryModule.java?0.00%?
    BackendRequest.java?100.00%?
    BackendResponse.java?100.00%?
    ClientHealthMetricsStore.java?0.00%?
    ClientMetrics.java?57.14%?
    Clock.java?0.00%?
    CreationContext.java?66.67%?
    CreationContextFactory.java?100.00%?
    CreationContextFactory_Factory.java?0.00%?
    DaggerTransportRuntimeComponent.java?0.00%?
    DefaultScheduler.java?80.00%?
    DefaultScheduler_Factory.java?0.00%?
    Destination.java?0.00%?
    EncodedDestination.java?0.00%?
    EncodedPayload.java?61.90%?
    EventInternal.java?60.00%?
    EventStore.java?0.00%?
    EventStoreConfig.java?100.00%?
    EventStoreModule.java?0.00%?
    EventStoreModule_DbNameFactory.java?0.00%?
    EventStoreModule_PackageNameFactory.java?0.00%?
    EventStoreModule_SchemaVersionFactory.java?0.00%?
    EventStoreModule_StoreConfigFactory.java?0.00%?
    ExecutionModule.java?0.00%?
    ExecutionModule_ExecutorFactory.java?0.00%?
    ForcedSender.java?0.00%?
    Function.java?0.00%?
    GlobalMetrics.java?0.00%?
    JobInfoScheduler.java?96.00%?
    JobInfoSchedulerService.java?0.00%?
    LogEventDropped.java?40.00%?
    Logging.java?47.06%?
    LogSourceMetrics.java?0.00%?
    MetadataBackendRegistry.java?66.67%?
    MetadataBackendRegistry_Factory.java?0.00%?
    Monotonic.java?0.00%?
    PersistedEvent.java?100.00%?
    PriorityMapping.java?88.89%?
    ProtoEncoderDoNotUse.java?50.00%?
    Retries.java?0.00%?
    RetryStrategy.java?0.00%?
    SafeLoggingExecutor.java?84.62%?
    Scheduler.java?0.00%?
    SchedulerConfig.java?98.53%?
    SchedulingConfigModule.java?0.00%?
    SchedulingConfigModule_ConfigFactory.java?0.00%?
    SchedulingModule.java?0.00%?
    SchedulingModule_WorkSchedulerFactory.java?0.00%?
    SchemaManager.java?98.65%?
    SchemaManager_Factory.java?0.00%?
    SendRequest.java?100.00%?
    SQLiteEventStore.java?39.16%?
    SQLiteEventStore_Factory.java?0.00%?
    StorageMetrics.java?0.00%?
    SynchronizationException.java?0.00%?
    SynchronizationGuard.java?0.00%?
    TestClock.java?40.00%?
    TimeModule.java?0.00%?
    TimeModule_EventClockFactory.java?0.00%?
    TimeModule_UptimeClockFactory.java?0.00%?
    TimeWindow.java?0.00%?
    TransportBackend.java?0.00%?
    TransportBackendDiscovery.java?0.00%?
    TransportContext.java?69.23%?
    TransportFactoryImpl.java?100.00%?
    TransportImpl.java?84.21%?
    TransportInternal.java?0.00%?
    TransportRuntime.java?66.15%?
    TransportRuntimeComponent.java?0.00%?
    TransportRuntime_Factory.java?0.00%?
    Uploader.java?95.45%?
    Uploader_Factory.java?0.00%?
    UptimeClock.java?100.00%?
    WallTime.java?0.00%?
    WallTimeClock.java?0.00%?
    WorkInitializer.java?0.00%?
    WorkInitializer_Factory.java?0.00%?
    WorkScheduler.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gUUaRA4uYJ.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Test Results

 40 files  + 20   40 suites  +20   43s ⏱️ +19s
211 tests +188  211 ✅ +188  0 💤 ±0  0 ❌ ±0 
422 runs  +354  422 ✅ +354  0 💤 ±0  0 ❌ ±0 

Results for commit b8ce056. ± Comparison against base commit bae6706.

This pull request removes 23 and adds 211 tests. Note that renamed tests count towards both. 
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…

com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 29, 2024 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (bae6706)Merge (9da1dce)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • transport-runtime

    TypeBase (bae6706)Merge (9da1dce)Diff
    aar?163 kB? (?)
    apk (aggressive)?55.7 kB? (?)
    apk (release)?193 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YywHCf4kO3.html

@rlazo rlazo merged commit 01bd3d7 into main Nov 29, 2024
33 checks passed
@rlazo rlazo deleted the rl.transport.manifest.cleanup branch November 29, 2024 17:02
@firebase firebase locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @VinayGuthal