Skip to content

Prevent whole session events from logging to logcat #6551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 3, 2024
Merged

Prevent whole session events from logging to logcat #6551

merged 6 commits into from
Dec 3, 2024

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from mrober December 2, 2024 22:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-sessions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 2, 2024 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (eeb23f7) and merge commit (2fdac67).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3O6qGZMyu5.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Test Results

 38 files  +18   38 suites  +18   59s ⏱️ +47s
 95 tests  - 18   95 ✅  - 18  0 💤 ±0  0 ❌ ±0 
190 runs   - 36  190 ✅  - 36  0 💤 ±0  0 ❌ ±0 

Results for commit 18462c9. ± Comparison against base commit eeb23f7.

This pull request removes 113 and adds 95 tests. Note that renamed tests count towards both. 
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 2, 2024 •
edited
Loading

Size Report 1

Affected Products

  • firebase-sessions

    TypeBase (eeb23f7)Merge (2fdac67)Diff
    aar168 kB168 kB-108 B (-0.1%)
    apk (aggressive)560 kB559 kB-172 B (-0.0%)
    apk (release)5.52 MB5.52 MB-176 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nYJkOxRvfp.html

rlazo
rlazo requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address SessionLifecycleService.kt too

@davidmotson davidmotson enabled auto-merge (squash) December 3, 2024 18:18
@davidmotson davidmotson disabled auto-merge December 3, 2024 18:20
@davidmotson davidmotson enabled auto-merge (squash) December 3, 2024 18:29
@davidmotson davidmotson merged commit 5628212 into main Dec 3, 2024
36 checks passed
@davidmotson davidmotson deleted the davidmotson.session_event_logging branch December 3, 2024 18:29
@firebase firebase locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidmotson @google-oss-bot @rlazo @mrober