Skip to content

Use version catalog for appcheck deps #6567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Dec 6, 2024

No description provided.

@rlazo rlazo requested review from daymxn and davidmotson December 6, 2024 00:41
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Results

 1 036 files  +   974   1 036 suites  +974   33m 3s ⏱️ + 31m 57s
 5 873 tests + 5 332   5 851 ✅ + 5 311  22 💤 +21  0 ❌ ±0 
11 831 runs  +10 749  11 787 ✅ +10 707  44 💤 +42  0 ❌ ±0 

Results for commit 458d920. ± Comparison against base commit 2190810.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (2190810)Merge (b555cd7)Diff
    apk (aggressive)390 kB390 kB-324 B (-0.1%)
    apk (release)4.88 MB4.88 MB-884 B (-0.0%)
  • firebase-appcheck-debug

    TypeBase (2190810)Merge (b555cd7)Diff
    apk (aggressive)396 kB396 kB-336 B (-0.1%)
    apk (release)4.89 MB4.89 MB-888 B (-0.0%)
  • firebase-appcheck-debug-testing

    TypeBase (2190810)Merge (b555cd7)Diff
    apk (aggressive)421 kB421 kB-328 B (-0.1%)
    apk (release)5.05 MB5.05 MB-884 B (-0.0%)
  • firebase-appcheck-interop

    TypeBase (2190810)Merge (b555cd7)Diff
    apk (aggressive)316 kB318 kB+2.26 kB (+0.7%)
    apk (release)1.84 MB1.71 MB-132 kB (-7.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1mn76STG3S.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.73% (2190810) to 45.72% (b555cd7) by -0.01%.

    FilenameBase (2190810)Merge (b555cd7)Diff
    LruGarbageCollector.java97.27%93.64%-3.64%
  • firebase-messaging

    Overall coverage changed from 84.19% (2190810) to 84.04% (b555cd7) by -0.15%.

    FilenameBase (2190810)Merge (b555cd7)Diff
    FirebaseMessaging.java76.40%76.00%-0.40%
    Metadata.java41.27%36.51%-4.76%
  • firebase-storage

    Overall coverage changed from 84.00% (2190810) to 83.96% (b555cd7) by -0.04%.

    FilenameBase (2190810)Merge (b555cd7)Diff
    NetworkRequest.java87.85%87.29%-0.55%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XBw7PIqWrU.html

@rlazo rlazo merged commit 033ab2d into main Dec 6, 2024
261 of 264 checks passed
@rlazo rlazo deleted the rl.version.catalog.appcheck branch December 6, 2024 15:32
@firebase firebase locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants