Skip to content

Various updates to datatransport #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2019
Merged

Various updates to datatransport #658

merged 2 commits into from
Jul 26, 2019

Conversation

vkryachko
Copy link
Member

  • Fix data race in initialize().
    The issue is that we were not doing the double-checked locking properly,
    which could manifest in instantiating multiple instances of
    TransportRuntime due to concurrent calls to initialize().
  • Set custom user-agent on requests to CCT.

vkryachko added 2 commits July 24, 2019 11:27
@vkryachko
Fix data race in initialize().
c67eb73 
The issue is that we were not doing the double-checked locking properly,
which could manifest in instantiating multiple instances of
TransportRuntime due to concurrent calls to initialize().
@vkryachko
Set custom user-agent on requests to CCT.
70657a3
@googlebot googlebot added the cla: yes Override cla label Jul 24, 2019
@vkryachko vkryachko requested a review from ashwinraghav July 25, 2019 00:29
@vkryachko vkryachko merged commit 4524ae7 into master Jul 26, 2019
@vkryachko vkryachko deleted the vk.transport_updates branch August 21, 2019 21:38
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashwinraghav ashwinraghav ashwinraghav approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @ashwinraghav @googlebot @google-oss-bot