Use the version catalog in the main build.gradle file #6590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, the entries in the version catalog have been sorted alphabetically.
Release note changesNo release note changes were detected. If you made changes that should be |
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Size Report 1Affected ProductsNo changes between base commit (8130292) and merge commit (55266ee).Test Logs |
Coverage Report 1Affected Products
Test Logs |
dconeybe
approved these changes
Dec 11, 2024
|
Something is up with the Firestore tests, as they're failing with this build error: |
…appear to break firestore
The Firestore build error is
```
firestore/src/androidTest/java/com/google/firebase/firestore/testutil/prod_provider/FirestoreProvider.java:39: error: cannot find symbol
return context.getString(R.string.project_id);
^
symbol: variable string
location: class R
```
|
I've pushed up a commit to downgrade com.google.gms:google-services back to 4.3.15, since 4.4.2 seems to be the culprit
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, the entries in the version catalog have been sorted alphabetically.