Skip to content

dataconnect.yml: ensure that test logs are uploaded even when the tests fail #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2025
Merged

dataconnect.yml: ensure that test logs are uploaded even when the tests fail #6670

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3fdebff
dataconnect.yml: ensure that test logs are uploaded even when the tes…
dconeybe Feb 4, 2025
d7f7097
dataconnect.yml: also capture adb logcat logs
dconeybe Feb 4, 2025
4f8d31f
dataconnect.yml: capture logcat for the entire duration of the test s…
dconeybe Feb 5, 2025
43c2785
dataconnect.yml: oops, forgot to fork adb logcat using '&'
dconeybe Feb 5, 2025
7c5f75d
empty commit to force github actions
dconeybe Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions .github/workflows/dataconnect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,16 @@ jobs:
cd firebase-dataconnect/emulator
${{ env.FDC_FIREBASE_COMMAND }} emulators:start --only=auth >firebase.emulator.auth.log 2>&1 &

- name: Capture Logcat Logs
run: adb logcat >logcat.log &

- name: Gradle connectedCheck
id: connectedCheck
uses: reactivecircus/android-emulator-runner@v2
# Allow this GitHub Actions "job" to continue even if the tests fail so that logs from a
# failed test run get uploaded as "artifacts" and are available to investigate failed runs.
# A later step in this "job" will fail the job if this step fails
continue-on-error: true
with:
api-level: ${{ env.FDC_ANDROID_EMULATOR_API_LEVEL }}
arch: x86_64
Expand All @@ -185,21 +193,28 @@ jobs:
script: |
set -eux && ./gradlew ${{ (inputs.gradleInfoLog && '--info') || '' }} :firebase-dataconnect:connectedCheck :firebase-dataconnect:connectors:connectedCheck

- uses: actions/upload-artifact@v4
if: true
- name: Upload log file artifacts
uses: actions/upload-artifact@v4
with:
name: logs
name: integration_test_logs
path: "**/*.log"
if-no-files-found: warn
compression-level: 9

- uses: actions/upload-artifact@v4
- name: Upload Gradle build report artifacts
uses: actions/upload-artifact@v4
with:
name: gradle_build_reports
name: integration_test_gradle_build_reports
path: firebase-dataconnect/**/build/reports/
if-no-files-found: warn
compression-level: 9

- name: Check test result
if: steps.connectedCheck.outcome != 'success'
run: |
echo "Failing the job since the connectedCheck step failed"
exit 1

# Check this yml file with "actionlint": https://github.com/rhysd/actionlint
# To run actionlint yourself, run `brew install actionlint` followed by
# `actionlint .github/workflows/dataconnect.yml`
Expand Down
Loading