Skip to content

Fix documentation for ImagenGenerationResponse #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

davidmotson
Copy link
Collaborator

No description provided.

Copy link

Important

The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ImagenGenerationResponse.html	2025-02-26 18:23:55.282898650 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/ImagenGenerationResponse.html	2025-02-26 18:21:42.485223255 +0000
@@ -11,7 +11,7 @@
       <pre>@<a href="/docs/reference/android/com/google/firebase/vertexai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>public final class <a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenGenerationResponse.html">ImagenGenerationResponse</a>&lt;T&nbsp;extends&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&gt;</pre>
     </p>
     <hr>
-    <p>Represents a response from a call to ImagenModel#generateImages</p>
+    <p>Represents a response from a call to <code><a href="/docs/reference/android/com/google/firebase/vertexai/ImagenModel.html#generateImages(kotlin.String)">ImagenModel.generateImages</a></code></p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
       <table class="responsive">
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/package-summary.html	2025-02-26 18:23:55.282898650 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/package-summary.html	2025-02-26 18:21:42.486223252 +0000
@@ -215,7 +215,7 @@
           <tr>
             <td><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/ImagenGenerationResponse.html">ImagenGenerationResponse</a></code></td>
             <td>
-              <p>Represents a response from a call to ImagenModel#generateImages</p>
+              <p>Represents a response from a call to <code><a href="/docs/reference/android/com/google/firebase/vertexai/ImagenModel.html#generateImages(kotlin.String)">ImagenModel.generateImages</a></code></p>
             </td>
           </tr>
           <tr>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ImagenGenerationResponse.html	2025-02-26 18:23:55.273898672 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/ImagenGenerationResponse.html	2025-02-26 18:21:42.476223279 +0000
@@ -11,7 +11,7 @@
       <pre>@<a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/PublicPreviewAPI.html">PublicPreviewAPI</a><br>class <a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenGenerationResponse.html">ImagenGenerationResponse</a>&lt;T&nbsp;:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?&gt;</pre>
     </p>
     <hr>
-    <p>Represents a response from a call to ImagenModel#generateImages</p>
+    <p>Represents a response from a call to <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/ImagenModel.html#generateImages(kotlin.String)">ImagenModel.generateImages</a></code></p>
     <h2>Summary</h2>
     <div class="devsite-table-wrapper">
       <table class="responsive">
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/package-summary.html	2025-02-26 18:23:55.274898670 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/vertexai/type/package-summary.html	2025-02-26 18:21:42.477223276 +0000
@@ -188,7 +188,7 @@
           <tr>
             <td><code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/type/ImagenGenerationResponse.html">ImagenGenerationResponse</a></code></td>
             <td>
-              <p>Represents a response from a call to ImagenModel#generateImages</p>
+              <p>Represents a response from a call to <code><a href="/docs/reference/kotlin/com/google/firebase/vertexai/ImagenModel.html#generateImages(kotlin.String)">ImagenModel.generateImages</a></code></p>
             </td>
           </tr>
           <tr>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@davidmotson davidmotson enabled auto-merge (squash) February 26, 2025 18:11
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 26, 2025

Copy link
Contributor

Test Results

 20 files   -  22   20 suites   - 22   12s ⏱️ - 1m 9s
116 tests  - 206  116 ✅  - 206  0 💤 ±0  0 ❌ ±0 
232 runs   - 424  232 ✅  - 424  0 💤 ±0  0 ❌ ±0 

Results for commit 74dd764. ± Comparison against base commit c3308a3.

This pull request removes 322 and adds 116 tests. Note that renamed tests count towards both.
com.google.firebase.remoteconfig.ConfigTests ‑ Custom Signals builder support multiple types
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance()
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region)
com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutDouble
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutDuplicateKeys
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutLong
com.google.firebase.remoteconfig.CustomSignalsTest ‑ testCustomSignals_builderPutMixedTypes
…
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (c3308a3)Merge (5291f0c)Diff
    aar576 kB576 kB+20 B (+0.0%)
    apk (release)9.36 MB9.36 MB+24 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tZ4chgxVuh.html

@davidmotson davidmotson merged commit 91ea30e into main Feb 26, 2025
29 of 30 checks passed
@davidmotson davidmotson deleted the davidmotson.vertex_doc_fix branch February 26, 2025 19:20
@firebase firebase locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants