[VertexAI] Add initial support to export covered API #6749

rlazo · 2025-03-10T04:53:20Z

The server produces a discovery document with the details of the API surface.

https://aiplatform.googleapis.com/$discovery/rest?version=v1beta1

This change introduces code that can generate similar a description of the API covered by the SDK. This will enable us to track difference between both.

In a follow up PR we can implement the logic to fully export the surface.

The code is not used in the SDK itself, so sholudn't be part of it.

Also, add missing header

github-actions · 2025-03-10T04:53:33Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2025-03-10T04:59:26Z

Coverage Report ¹

Affected Products

No changes between base commit (a232b6d) and merge commit (3a103b0).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/KgLIujjwfO.html

github-actions · 2025-03-10T05:00:04Z

Test Results

22 files + 8 22 suites +8 12s ⏱️ ±0s
121 tests + 98 121 ✅ + 98 0 💤 ±0 0 ❌ ±0
242 runs +196 242 ✅ +196 0 💤 ±0 0 ❌ ±0

Results for commit 39e5671. ± Comparison against base commit a232b6d.

This pull request removes 23 and adds 121 tests. Note that renamed tests count towards both.

com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…

com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2025-03-10T05:04:33Z

Size Report ¹

Affected Products

firebase-vertexai
Type Base (a232b6d) Merge (3a103b0) Diff
aar 576 kB 578 kB +1.83 kB (+0.3%)
apk (aggressive) 1.40 MB 1.40 MB +564 B (+0.0%)
apk (release) 9.36 MB 9.36 MB +1.11 kB (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/FTxRWG4Gio.html

daymxn

Left some comments, but otherwise LGTM

firebase-vertexai/src/test/java/com/google/firebase/vertexai/SerializationTests.kt

firebase-vertexai/src/test/java/com/google/firebase/vertexai/common/util/descriptorToJson.kt

…erializationTests.kt Co-authored-by: Daymon <[email protected]>

The server produces a discovery document with the details of the API surface. https://aiplatform.googleapis.com/$discovery/rest?version=v1beta1 This change introduces code that can generate similar a description of the API covered by the SDK. This will enable us to track difference between both. In a follow up PR we can implement the logic to fully export the surface. --------- Co-authored-by: Daymon <[email protected]>

rlazo added 9 commits March 6, 2025 23:16

Initial version of the serialization to json functionality

2377948

Move JSON format to more closely ressemble a discovery document

e6904a2

Implement map operation as used by the Schema struct

04a76b8

Undo version change

ab7f6a9

Rename method and remove dead code

f3945d0

Move code to test directory

a0ec909

The code is not used in the SDK itself, so sholudn't be part of it.

Use a non-colliding name for the util

971ccb6

Simplify code to make it easier to read

d56e534

Use the same name for the file as for the method

4e442c6

Also, add missing header

rlazo requested review from emilypgoogle and daymxn March 10, 2025 04:53

google-oss-bot added the size/L label Mar 10, 2025

Merge branch 'main' into rl.ser.to.json

3788154

rlazo added the no-changelog label Mar 10, 2025

daymxn approved these changes Mar 10, 2025

View reviewed changes

rlazo changed the title ~~Add initial support to export covered API~~ [VertexAI] Add initial support to export covered API Mar 10, 2025

rlazo and others added 4 commits March 10, 2025 12:41

Update firebase-vertexai/src/test/java/com/google/firebase/vertexai/S…

4c03d23

…erializationTests.kt Co-authored-by: Daymon <[email protected]>

Add comment over TODO to describe the scenario

02d67c5

Add description for the simpleNameFromSerialName function

c139938

Merge branch 'main' into rl.ser.to.json

39e5671

rlazo merged commit 123c9d7 into main Mar 10, 2025
31 checks passed

rlazo deleted the rl.ser.to.json branch March 10, 2025 17:33

firebase locked and limited conversation to collaborators Apr 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[VertexAI] Add initial support to export covered API #6749

[VertexAI] Add initial support to export covered API #6749

Uh oh!

rlazo commented Mar 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 10, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Mar 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 10, 2025 •

edited

Loading

Uh oh!

google-oss-bot commented Mar 10, 2025 •

edited

Loading

`firebase-vertexai`

Uh oh!

daymxn left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[VertexAI] Add initial support to export covered API #6749

[VertexAI] Add initial support to export covered API #6749

Uh oh!

Conversation

rlazo commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

Test Logs

Uh oh!

github-actions bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

google-oss-bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-vertexai

Test Logs

Uh oh!

daymxn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rlazo commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading

google-oss-bot commented Mar 10, 2025 •

edited

Loading

Coverage Report ¹

github-actions bot commented Mar 10, 2025 •

edited

Loading

google-oss-bot commented Mar 10, 2025 •

edited

Loading

Size Report ¹

`firebase-vertexai`