Skip to content

[Functions] Bump all test timeouts to 10 seconds #6821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

[Functions] Bump all test timeouts to 10 seconds #6821

merged 1 commit into from
Mar 28, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 28, 2025 •
edited
Loading

Integration tests are being flaky due to short timeouts.

no-changelog

@rlazo
[Functions] Bump all test timeouts to 10 seconds
02aaed8 
Integration tests are being flaky  due to short timeouts.
@rlazo rlazo requested a review from daymxn March 28, 2025 22:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@rlazo rlazo requested a review from VinayGuthal March 28, 2025 22:30
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo enabled auto-merge (squash) March 28, 2025 22:33
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (9da772e) and merge commit (f32cd28).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qk0vG7r1ew.html

@github-actions GitHub Actions
Copy link
Contributor

Test Results

14 files   -  1 020  14 suites   - 1 020   11s ⏱️ - 34m 22s
23 tests  -  5 849  23 ✅  -  5 827  0 💤  - 22  0 ❌ ±0 
46 runs   - 11 761  46 ✅  - 11 717  0 💤  - 44  0 ❌ ±0 

Results for commit 02aaed8. ± Comparison against base commit 9da772e.

This pull request removes 5849 tests. 
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@rlazo rlazo merged commit e65e93f into main Mar 28, 2025
34 checks passed
@rlazo rlazo deleted the rl.functions.timeout.10 branch March 28, 2025 22:37
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (9da772e) and merge commit (f32cd28).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lkVcFZ0Dz1.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fn

    DeviceStatisticsDistributions
    oriole-32
    Percentile9da772ef32cd28DiffSignificant (?)
    p1084.2 ±9 μs83.8 ±6 μs-398 ns (-0.5%)NO
    p2590.4 ±12 μs88.3 ±6 μs-2.03 μs (-2.2%)NO
    p50100 ±18 μs95.2 ±5 μs-5.07 μs (-5.1%)NO
    p75117 ±28 μs113 ±16 μs-4.21 μs (-3.6%)NO
    p90135 ±39 μs146 ±33 μs+11.2 μs (+8.3%)NO

    20 test runs in comparison
    CommitTest Runs
    9da772e
    • 2025-03-28_21:18:29.367153_uDOA
    • 2025-03-28_21:18:29.367186_joJy
    • 2025-03-28_21:18:29.367197_ZizX
    • 2025-03-28_21:18:29.367206_TsMk
    • 2025-03-28_21:18:29.367214_HOtg
    • 2025-03-28_21:18:29.367221_EXoU
    • 2025-03-28_21:18:29.367227_GDCv
    • 2025-03-28_21:18:29.367234_seQd
    • 2025-03-28_21:18:29.367241_ZySL
    • 2025-03-28_21:18:29.367248_tgLi
    f32cd28
    • 2025-03-28_22:46:27.240822_jKMu
    • 2025-03-28_22:46:27.240858_VSlq
    • 2025-03-28_22:46:27.240868_xpMd
    • 2025-03-28_22:46:27.240876_sMRE
    • 2025-03-28_22:46:27.240883_fuJP
    • 2025-03-28_22:46:27.240891_qTxy
    • 2025-03-28_22:46:27.240898_VjCK
    • 2025-03-28_22:46:27.240904_zMFl
    • 2025-03-28_22:46:27.240911_tDSo
    • 2025-03-28_22:46:27.240917_EzQT
    redfin-30
    Percentile9da772ef32cd28DiffSignificant (?)
    p10155 ±13 μs154 ±11 μs-1.31 μs (-0.8%)NO
    p25162 ±15 μs162 ±12 μs+255 ns (+0.2%)NO
    p50172 ±18 μs173 ±14 μs+1.55 μs (+0.9%)NO
    p75187 ±22 μs190 ±21 μs+2.94 μs (+1.6%)NO
    p90199 ±25 μs211 ±27 μs+12.0 μs (+6.0%)NO

    20 test runs in comparison
    CommitTest Runs
    9da772e
    • 2025-03-28_21:18:29.367153_uDOA
    • 2025-03-28_21:18:29.367186_joJy
    • 2025-03-28_21:18:29.367197_ZizX
    • 2025-03-28_21:18:29.367206_TsMk
    • 2025-03-28_21:18:29.367214_HOtg
    • 2025-03-28_21:18:29.367221_EXoU
    • 2025-03-28_21:18:29.367227_GDCv
    • 2025-03-28_21:18:29.367234_seQd
    • 2025-03-28_21:18:29.367241_ZySL
    • 2025-03-28_21:18:29.367248_tgLi
    f32cd28
    • 2025-03-28_22:46:27.240822_jKMu
    • 2025-03-28_22:46:27.240858_VSlq
    • 2025-03-28_22:46:27.240868_xpMd
    • 2025-03-28_22:46:27.240876_sMRE
    • 2025-03-28_22:46:27.240883_fuJP
    • 2025-03-28_22:46:27.240891_qTxy
    • 2025-03-28_22:46:27.240898_VjCK
    • 2025-03-28_22:46:27.240904_zMFl
    • 2025-03-28_22:46:27.240911_tDSo
    • 2025-03-28_22:46:27.240917_EzQT

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile9da772ef32cd28DiffSignificant (?)
    p10200 ±3 ms199 ±3 ms-1.28 ms (-0.6%)NO
    p25206 ±5 ms204 ±3 ms-1.86 ms (-0.9%)NO
    p50213 ±6 ms211 ±3 ms-2.33 ms (-1.1%)NO
    p75222 ±7 ms220 ±3 ms-1.60 ms (-0.7%)NO
    p90232 ±13 ms230 ±3 ms-1.82 ms (-0.8%)NO

    20 test runs in comparison
    CommitTest Runs
    9da772e
    • 2025-03-28_21:18:29.367153_uDOA
    • 2025-03-28_21:18:29.367186_joJy
    • 2025-03-28_21:18:29.367197_ZizX
    • 2025-03-28_21:18:29.367206_TsMk
    • 2025-03-28_21:18:29.367214_HOtg
    • 2025-03-28_21:18:29.367221_EXoU
    • 2025-03-28_21:18:29.367227_GDCv
    • 2025-03-28_21:18:29.367234_seQd
    • 2025-03-28_21:18:29.367241_ZySL
    • 2025-03-28_21:18:29.367248_tgLi
    f32cd28
    • 2025-03-28_22:46:27.240822_jKMu
    • 2025-03-28_22:46:27.240858_VSlq
    • 2025-03-28_22:46:27.240868_xpMd
    • 2025-03-28_22:46:27.240876_sMRE
    • 2025-03-28_22:46:27.240883_fuJP
    • 2025-03-28_22:46:27.240891_qTxy
    • 2025-03-28_22:46:27.240898_VjCK
    • 2025-03-28_22:46:27.240904_zMFl
    • 2025-03-28_22:46:27.240911_tDSo
    • 2025-03-28_22:46:27.240917_EzQT
    redfin-30
    Percentile9da772ef32cd28DiffSignificant (?)
    p10223 ±4 ms248 ±6 ms+24.7 ms (+11.1%)MAYBE
    p25230 ±4 ms254 ±6 ms+24.6 ms (+10.7%)MAYBE
    p50237 ±4 ms262 ±6 ms+25.1 ms (+10.6%)MAYBE
    p75245 ±4 ms271 ±7 ms+25.7 ms (+10.5%)MAYBE
    p90253 ±3 ms284 ±9 ms+30.7 ms (+12.1%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    9da772e
    • 2025-03-28_21:18:29.367153_uDOA
    • 2025-03-28_21:18:29.367186_joJy
    • 2025-03-28_21:18:29.367197_ZizX
    • 2025-03-28_21:18:29.367206_TsMk
    • 2025-03-28_21:18:29.367214_HOtg
    • 2025-03-28_21:18:29.367221_EXoU
    • 2025-03-28_21:18:29.367227_GDCv
    • 2025-03-28_21:18:29.367234_seQd
    • 2025-03-28_21:18:29.367241_ZySL
    • 2025-03-28_21:18:29.367248_tgLi
    f32cd28
    • 2025-03-28_22:46:27.240822_jKMu
    • 2025-03-28_22:46:27.240858_VSlq
    • 2025-03-28_22:46:27.240868_xpMd
    • 2025-03-28_22:46:27.240876_sMRE
    • 2025-03-28_22:46:27.240883_fuJP
    • 2025-03-28_22:46:27.240891_qTxy
    • 2025-03-28_22:46:27.240898_VjCK
    • 2025-03-28_22:46:27.240904_zMFl
    • 2025-03-28_22:46:27.240911_tDSo
    • 2025-03-28_22:46:27.240917_EzQT

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ebR6YQWBld/index.html

tejasd pushed a commit that referenced this pull request Apr 1, 2025
@rlazo @tejasd
[Functions] Bump all test timeouts to 10 seconds (#6821)
afa1197 
Integration tests are being flaky  due to short timeouts.

no-changelog
@firebase firebase locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

@VinayGuthal VinayGuthal Awaiting requested review from VinayGuthal

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @daymxn