Skip to content

dataconnect: QuerySubscriptionIntegrationTest.kt: fix flaky test using backgroundScope #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 2, 2025

Fix a flaky test by ensuring that the query subscription started in backgroundScope gets its first result before continuing the test.

…the query subscription started in backgroundScope gets its first result before continuing the test.
Copy link
Contributor

github-actions bot commented Apr 2, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Test Results

   66 files  ±0     66 suites  ±0   1m 21s ⏱️ +4s
  552 tests ±0    551 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 104 runs  ±0  1 102 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a89d7ca. ± Comparison against base commit 2cdac31.

@google-oss-bot
Copy link
Contributor

@dconeybe dconeybe marked this pull request as ready for review April 2, 2025 13:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • firebase-dataconnect/src/androidTest/kotlin/com/google/firebase/dataconnect/QuerySubscriptionIntegrationTest.kt: Language not supported

@dconeybe dconeybe merged commit 75cdf96 into main Apr 2, 2025
50 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/CollectFlakyTestFix branch April 2, 2025 16:45
@firebase firebase locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants