dataconnect: github actions cache key fix #6829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to verify that they run correctly.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
dconeybe
changed the title
Size Report 1Affected ProductsNo changes between base commit (3d41253) and merge commit (4718073).Test Logs |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a warning in the GitHub Actions workflow related to missing keys during nightly runs by replacing references to skipped step outputs with hard-coded cache key prefixes suffixed by the unique run ID.
- Updated the Gradle cache key to use a fixed prefix concatenated with the GitHub run ID.
- Updated the AVD cache key to include the Android emulator API level and the GitHub run ID.
Comments suppressed due to low confidence (1)
.github/workflows/dataconnect.yml:166
- [nitpick] Consider adding a hyphen after 'api' (e.g., 'api-${{ env.FDC_ANDROID_EMULATOR_API_LEVEL }}') to improve readability and consistency in the cache key format.
key: avd-cache-zhdsn586je-api${{ env.FDC_ANDROID_EMULATOR_API_LEVEL }}-${{ github.run_id }}
…D" step by using `cache-matched-key` instead of `cache-hit` See https://github.com/actions/cache/tree/main/restore
Coverage Report 1Affected Products
Test Logs |
aashishpatil-g
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Warning: Key is not specified" warning in the scheduled nightly runs in the "Save Gradle cache" and "Save AVD cache" steps of the dataconnect github actions workflow. The problem was that it was defining the key as
${{ steps.restore-gradle-cache.outputs.cache-primary-key }}and${{ steps.restore-avd-cache.outputs.cache-primary-key }}, respectively, but since those dependent steps were explicitly skipped in nightly runs their outputs were not defined.