Skip to content

Add spec test for limit query initialization #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2019
Merged

Add spec test for limit query initialization #683

merged 1 commit into from
Aug 2, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

@googlebot googlebot added the cla: yes Override cla label Aug 2, 2019
thebrianchen
thebrianchen approved these changes Aug 2, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit 5669699 into master Aug 2, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/initiallimit branch August 27, 2019 23:45
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @thebrianchen @googlebot @google-oss-bot