dataconnect: fix flaky test that ensures deserialize() throws IllegalArgumentException on invalid input

[dconeybe]

Fix unparseableDash() in LocalDateSerializerUnitTest.kt to not include numbers in the set of "invalid" characters because they become "valid" when adjacent to other numeric digits. In certain situations, using a "digit" as an invalid character was causing flaky test failures such as this one in deserialize() should throw IllegalArgumentException when given unparseable strings:

Arg 0: "96-082895-312"

Repeat this test by using seed -7108070269336260794

Caused by: Expected exception java.lang.IllegalArgumentException but no exception was thrown.
	at com.google.firebase.dataconnect.serializers.LocalDateSerializerUnitTest$deserialize() should throw IllegalArgumentException when given unparseable strings$1.invokeSuspend(LocalDateSerializerUnitTest.kt:104)
	at com.google.firebase.dataconnect.serializers.LocalDateSerializerUnitTest$deserialize() should throw IllegalArgumentException when given unparseable strings$1.invoke(LocalDateSerializerUnitTest.kt)
	at com.google.firebase.dataconnect.serializers.LocalDateSerializerUnitTest$deserialize() should throw IllegalArgumentException when given unparseable strings$1.invoke(LocalDateSerializerUnitTest.kt)

Note that the string "96-082895-312" is 3 valid numbers separated by dashes and, therefore, is successfully parsed as a date. The "-0" was the string produced by unparseableDash() which, when combined with the rest of the string, did not, in fact, produce an unparseable dash.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[google-oss-bot]

Coverage Report ¹

Affected Products

No changes between base commit (a0a02a7) and merge commit (d04bb32).

Test Logs

• Base (a0a02a7): https://github.com/firebase/firebase-android-sdk/actions/runs/14226258905
• Merge (d04bb32): https://github.com/firebase/firebase-android-sdk/actions/runs/14271360583

1. https://storage.googleapis.com/firebase-sdk-metric-reports/wNLlpUYbnJ.html

[github-actions]

Test Results

   66 files   -    968     66 suites   - 968   1m 11s ⏱️ - 33m 8s
  552 tests  -  5 320    551 ✅  -  5 299  1 💤  - 21  0 ❌ ±0 
1 104 runs   - 10 703  1 102 ✅  - 10 661  2 💤  - 42  0 ❌ ±0 

Results for commit 7a500d1. ± Comparison against base commit a0a02a7.

This pull request removes 5320 tests.

com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (a0a02a7) and merge commit (d04bb32).

Test Logs

• Base (a0a02a7): https://github.com/firebase/firebase-android-sdk/actions/runs/14226258905
• Merge (d04bb32): https://github.com/firebase/firebase-android-sdk/actions/runs/14271360583

1. https://storage.googleapis.com/firebase-sdk-metric-reports/ERWZwXVILH.html

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.