Update RTDB Error message to point to GitHub #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/errormsg
branch
2 times, most recently
from
a7402dc to
5662b50
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/errormsg
branch
from
5662b50 to
73e784a
Compare
|
cc @katowulf |
|
/test device-check-changed |
mikelehen
approved these changes
Aug 5, 2019
| return "A symbol that the Firebase Database SDK depends on failed to load. This usually " | ||
| + "indicates that your project includes an incompatible version of another Firebase " | ||
| + "dependency. If updating your dependencies to the latest version does not resolve " | ||
| + "this issue, please file a report at https://github.com/firebase/firebase-android-sdk"; |
There was a problem hiding this comment.
If you want to be more helpful, change these URLs to https://github.com/firebase/firebase-android-sdk/issues/new?template=bug.md
If you want to be less helpful, change it to "on github" 😛
There was a problem hiding this comment.
Left it as is for now. I deem it to be the right level of helpfulness :)
| } else if (t instanceof DatabaseException) { | ||
| // Exception should be self-explanatory and they shouldn't contact support. | ||
| return ""; | ||
| } else { | ||
| return "Uncaught exception in Firebase Database runloop (" | ||
| + FirebaseDatabase.getSdkVersion() | ||
| + "). Please report to [email protected]"; | ||
| + "). If this is not a problem with your app, please file an issue at " | ||
| + " https://github.com/firebase/firebase-android-sdk"; |
There was a problem hiding this comment.
FWIW- You could add something about "make sure you're using the latest version of the SDK" if you want to potentially decrease noise level a little more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the public facing error message that the RTDB shows when all else fails.
It special-cases NoClassDefFoundErrors as these are very common lately (due to the changes in Auth integration) and generally recommends GitHub over our email for any other issues.