Skip to content

use bytestream instead of bytearray #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

use bytestream instead of bytearray #6847

merged 1 commit into from
Apr 8, 2025

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Test Results

 18 files   -    75   18 suites   - 75   14s ⏱️ - 6m 11s
 86 tests  -   581   86 ✅  -   581  0 💤 ±0  0 ❌ ±0 
172 runs   - 1 143  172 ✅  - 1 143  0 💤 ±0  0 ❌ ±0 

Results for commit 7cf824a. ± Comparison against base commit f97833e.

This pull request removes 667 and adds 86 tests. Note that renamed tests count towards both.
com.google.android.datatransport.runtime.SafeLoggingExecutorTest ‑ execute_shouldNotCrashThread
com.google.android.datatransport.runtime.TransportContextTest ‑ shouldUploadClientHealthMetrics_returnFalseExtrasIsEmpty
com.google.android.datatransport.runtime.TransportContextTest ‑ shouldUploadClientHealthMetrics_returnTrueExtrasIsNotEmpty
com.google.android.datatransport.runtime.TransportContextTest ‑ withPriority_whenPriorityChangedBackToOriginal_shouldReturnEqualContext
com.google.android.datatransport.runtime.TransportContextTest ‑ withPriority_whenPriorityIsDifferent_shouldReturnContextWithPriorityChanged
com.google.android.datatransport.runtime.TransportContextTest ‑ withPriority_whenPriorityNotChanged_shouldReturnEqualContext
com.google.android.datatransport.runtime.TransportRuntimeTest ‑ newFactory_withDestination_shouldSupportProtobuf
com.google.android.datatransport.runtime.TransportRuntimeTest ‑ newFactory_withExtendedDestination_shouldSupportYaml
com.google.android.datatransport.runtime.TransportRuntimeTest ‑ testTransportInternalSend
com.google.android.datatransport.runtime.TransportRuntimeTest ‑ testTransportRuntimeBackendDiscovery
…
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (f97833e)Merge (d4cbd58)Diff
    aar768 kB768 kB+73 B (+0.0%)
    apk (aggressive)1.53 MB1.53 MB-52 B (-0.0%)
    apk (release)9.49 MB9.49 MB+64 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TMd0ZCV5h5.html

@VinayGuthal VinayGuthal merged commit 6e3be78 into main Apr 8, 2025
30 of 31 checks passed
@VinayGuthal VinayGuthal deleted the use_byte_stream branch April 8, 2025 20:22
@firebase firebase locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants