Skip to content

FirebaseDataConnectImpl.kt: use MutableStateFlow to store state, rather than mutexes #6861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e0feba9
DataConnectCredentialsTokenManager.kt: use MutableStateFlow instead o…
dconeybe Apr 4, 2025
2adbdfe
DataConnectCredentialsTokenManager.kt: clean up State sealed interface
dconeybe Apr 4, 2025
ee8fbf3
DataConnectCredentialsTokenManager.kt: awaitTokenProvider() added
dconeybe Apr 4, 2025
68f3ada
FirebaseDataConnectInternalExts.kt: add extension functions: Firebase…
dconeybe Apr 4, 2025
6010e49
empty commit to re-trigger github actions
dconeybe Apr 4, 2025
633e68f
Merge branch 'main' into dconeybe/dataconnect/AuthCodeCleanup
dconeybe Apr 4, 2025
415215c
dataconnect: Use MutableStateFlow.update() instead of MutableStateFlo…
dconeybe Apr 4, 2025
12358d9
Merge branch 'main' into dconeybe/dataconnect/AuthCodeCleanup
dconeybe Apr 5, 2025
2d092f8
Merge branch 'dconeybe/dataconnect/AuthCodeCleanup' into dconeybe/dat…
dconeybe Apr 5, 2025
e9b91a7
Merge remote-tracking branch 'origin/main' into MutableStateFlowUseUp…
dconeybe Apr 8, 2025
c0bca78
Merge remote-tracking branch 'origin/main' into MutableStateFlowUseUp…
dconeybe Apr 9, 2025
c9d70a3
FirebaseDataConnectImpl.kt: fix minor typo in comment
dconeybe Apr 9, 2025
9658ae4
FirebaseDataConnectImpl.kt: use MutableStateFlow to store state, rath…
dconeybe Apr 10, 2025
4c47941
Merge branch 'main' into dconeybe/dataconnect/MutableStateFlowUseUpda…
dconeybe Apr 15, 2025
3aef735
minor cleanup
dconeybe Apr 15, 2025
2888ef9
Merge branch 'MutableStateFlowUseUpdateInsteadOfCompareAndSet' into F…
dconeybe Apr 15, 2025
c762afd
minor cleanup
dconeybe Apr 15, 2025
c7b19c0
Merge branch 'main' into dconeybe/dataconnect/MutableStateFlowUseUpda…
dconeybe Apr 15, 2025
990b568
Merge branch 'main' into dconeybe/dataconnect/MutableStateFlowUseUpda…
dconeybe Apr 16, 2025
a02618e
Merge branch 'dconeybe/dataconnect/MutableStateFlowUseUpdateInsteadOf…
dconeybe Apr 16, 2025
9f3b794
Rename "old" state variables to "current" state, as suggested by Copi…
dconeybe Apr 16, 2025
7e48219
Rename "old" state variables to "current" state, as suggested by Copi…
dconeybe Apr 16, 2025
4d6c97e
Merge branch 'MutableStateFlowUseUpdateInsteadOfCompareAndSet' into F…
dconeybe Apr 16, 2025
b1f01b0
DataConnectCredentialsTokenManager.kt: verify the new state in forceR…
dconeybe Apr 16, 2025
e19950e
Merge branch 'MutableStateFlowUseUpdateInsteadOfCompareAndSet' into F…
dconeybe Apr 16, 2025
8af55c9
Merge remote-tracking branch 'origin/main' into FirebaseDataConnectIm…
dconeybe Apr 16, 2025
7946f5a
fix build due to bad merge
dconeybe Apr 16, 2025
5555f2b
Merge branch 'main' into dconeybe/dataconnect/FirebaseDataConnectImpl…
dconeybe Apr 22, 2025
b8f0fc2
CHANGELOG.md entry added
dconeybe Apr 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion firebase-dataconnect/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased

* [changed] Code robustness improvements related to state management in
`FirebaseDataConnect` objects.
([#6861](https://github.com/firebase/firebase-android-sdk/pull/6861))

# 16.0.0
* [changed] DataConnectOperationException added, enabling support for partial
Expand Down
Loading
Loading