Skip to content

[ai] Use .json for unary tests instead of .txt #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 29, 2025
Merged

[ai] Use .json for unary tests instead of .txt #6916

Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5c22a5e
Copy vertexai to firebase-ai
Apr 23, 2025
a5a068f
revert changes to firebase-vertexai dir
Apr 24, 2025
40a16cc
add changes to match the new api spec, add imagen, and google-ai supp…
davidmotson Apr 25, 2025
c1c507f
remove unneeded diffs
Apr 25, 2025
4b505c1
Merge branch 'main' into davidmotson.firebase-ai
davidmotson Apr 25, 2025
df6a6ed
revert submodule updates
Apr 25, 2025
def369c
fix for jules
Apr 25, 2025
2915966
Update firebase-ai/lint-baseline.xml
davidmotson Apr 25, 2025
8287ce2
Update firebase-ai/src/test/resources/README.md
davidmotson Apr 25, 2025
8f05b13
Update firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAIM…
davidmotson Apr 25, 2025
5d1a95c
Update firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
davidmotson Apr 25, 2025
197b090
Merge branch 'main' into davidmotson.firebase-ai
davidmotson Apr 25, 2025
268bcca
[ai] Address most tests failures (#6915)
rlazo Apr 28, 2025
318feaa
remove test that keeps timing out
Apr 28, 2025
3fdd552
format
Apr 28, 2025
73a0377
[ai] Use .json for unary tests instead of .txt
rlazo Apr 28, 2025
bf5dd10
Merge branch 'davidmotson.firebase-ai' into rl.txt.to.json.ai
rlazo Apr 28, 2025
c4ea253
Merge branch 'main' into rl.txt.to.json.ai
rlazo Apr 29, 2025
390e773
Remove duplicated test
rlazo Apr 29, 2025
e969f46
Fix format
rlazo Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions firebase-ai/src/test/java/com/google/firebase/ai/DevAPIUnarySnapshotTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal class DevAPIUnarySnapshotTests {

@Test
fun `short reply`() =
goldenDevAPIUnaryFile("unary-success-basic-reply-short.txt") {
goldenDevAPIUnaryFile("unary-success-basic-reply-short.json") {
withTimeout(testTimeout) {
val response = model.generateContent("prompt")

Expand All @@ -47,7 +47,7 @@ internal class DevAPIUnarySnapshotTests {

@Test
fun `long reply`() =
goldenDevAPIUnaryFile("unary-success-basic-reply-long.txt") {
goldenDevAPIUnaryFile("unary-success-basic-reply-long.json") {
withTimeout(testTimeout) {
val response = model.generateContent("prompt")

Expand Down Expand Up @@ -85,14 +85,14 @@ internal class DevAPIUnarySnapshotTests {

@Test
fun `invalid api key`() =
goldenDevAPIUnaryFile("unary-failure-api-key.txt", HttpStatusCode.BadRequest) {
goldenDevAPIUnaryFile("unary-failure-api-key.json", HttpStatusCode.BadRequest) {
withTimeout(testTimeout) {
shouldThrow<InvalidAPIKeyException> { model.generateContent("prompt") }
}
}
@Test
fun `unknown model`() =
goldenDevAPIUnaryFile("unary-failure-unknown-model.txt", HttpStatusCode.NotFound) {
goldenDevAPIUnaryFile("unary-failure-unknown-model.json", HttpStatusCode.NotFound) {
withTimeout(testTimeout) { shouldThrow<ServerException> { model.generateContent("prompt") } }
}
}
Loading