Skip to content

Add missing GaugeCounter increment. #6966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Add missing GaugeCounter increment. #6966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b67eee5
Add missing Gauge Increment
tejasd May 16, 2025
6d2eef6
remove .INSTANCE
tejasd May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/CpuGaugeCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ private synchronized void scheduleCpuMetricCollectionOnce(Timer referenceTime) {
CpuMetricReading currCpuReading = syncCollectCpuMetric(referenceTime);
if (currCpuReading != null) {
cpuMetricReadings.add(currCpuReading);
GaugeCounter.INSTANCE.incrementCounter();
}
},
/* initialDelay */ 0,
Expand Down
1 change: 1 addition & 0 deletions ...base-perf/src/main/java/com/google/firebase/perf/session/gauges/MemoryGaugeCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ private synchronized void scheduleMemoryMetricCollectionOnce(Timer referenceTime
AndroidMemoryReading memoryReading = syncCollectMemoryMetric(referenceTime);
if (memoryReading != null) {
memoryMetricReadings.add(memoryReading);
GaugeCounter.INSTANCE.incrementCounter();
}
},
/* initialDelay */ 0,
Expand Down
4 changes: 2 additions & 2 deletions firebase-perf/src/test/java/com/google/firebase/perf/session/gauges/GaugeManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public void testGaugeCounterStartsAJobToConsumeTheGeneratedMetrics() throws Inte
PerfSession fakeSession = createTestSession(1);
testGaugeManager.setApplicationProcessState(ApplicationProcessState.FOREGROUND);
testGaugeManager.startCollectingGauges(fakeSession);
GaugeCounter.INSTANCE.setGaugeManager(testGaugeManager);
GaugeCounter.setGaugeManager(testGaugeManager);

// There's no job to log the gauges.
assertThat(fakeScheduledExecutorService.isEmpty()).isTrue();
Expand Down Expand Up @@ -377,7 +377,7 @@ public void testUpdateAppStateHandlesMultipleAppStates() {
fakeSession.setGaugeAndEventCollectionEnabled(true);
testGaugeManager.setApplicationProcessState(ApplicationProcessState.FOREGROUND);
testGaugeManager.startCollectingGauges(fakeSession);
GaugeCounter.INSTANCE.setGaugeManager(testGaugeManager);
GaugeCounter.setGaugeManager(testGaugeManager);

// Generate metrics that don't exceed the GaugeCounter.MAX_COUNT.
generateMetricsAndIncrementCounter(10);
Expand Down
Loading