Skip to content

Allow user to stop listening after shutdown + other minor fixes. #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2019
Merged

Allow user to stop listening after shutdown + other minor fixes. #701

merged 3 commits into from
Aug 12, 2019

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Aug 12, 2019

  • Allow user to stop listening after shutdown

  • EventManager.removeQueryListener should return void

  • add missing check for callback existence in EventManager

@googlebot googlebot added the cla: yes Override cla label Aug 12, 2019
@wu-hui wu-hui requested a review from mikelehen August 12, 2019 17:17
mikelehen
mikelehen approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning up the platform inconsistencies!

@mikelehen mikelehen assigned wu-hui and unassigned mikelehen Aug 12, 2019
@wu-hui wu-hui merged commit 3057375 into master Aug 12, 2019
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@wu-hui wu-hui

Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @mikelehen @googlebot @google-oss-bot