-
Notifications
You must be signed in to change notification settings - Fork 619
Merge main #7016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge main #7016
Changes from all commits
Commits
Show all changes
162 commits
Select commit
Hold shift + click to select a range
e37be5a
add new recipe entries to BoM generator (#6702)
davidmotson aa97aa3
Improve imagen Java API (#6712)
rlazo 680ce8c
Remove test code left by mistake (#6717)
rlazo 22be120
Add missing optIn declarations to reduce compilation noise (#6713)
rlazo a2244f9
Support custom tabs in more browsers (#6705)
Fry-kun 5712a26
Update CHANGELOG for Crashlytics and NDK (#6719)
mrober 4cf2825
Bump well known types (#6716)
daymxn 1e8c218
Update CHANGELOG.md (#6718)
lfkellogg c3308a3
Add custom signal limits link and fix Javadoc List Formatting (#6722)
tusharkhandelwal8 91ea30e
Fix documentation for ImagenGenerationResponse (#6728)
davidmotson ba0941b
Add copyApiTxtFile task (#6724)
emilypgoogle 043bdc0
dataconnect: minor cosmetic changes to the github actions workflow (#…
dconeybe 72c0dcb
Bump truth from 1.4.2 to 1.4.4 (#6723)
dependabot[bot] 9f96db8
Bump semver from 7.5.0 to 7.5.4 in /smoke-tests/src/androidTest/backe…
dependabot[bot] 3e54107
build(deps): bump com.fasterxml.jackson.core:jackson-databind from 2.…
dependabot[bot] 00c2919
dataconnect: DataConnectExecutableVersions.json updated with versions…
dconeybe 16d2ba8
dataconnect: change grpc api version from "v1beta" to "v1" (#6729)
dconeybe ad7618b
Add Metalava SemVer Task (#6725)
emilypgoogle ec26a52
Use lazy encoding in utf-8 encoded string comparison (#6706)
milaGGL d701c34
Avoid Process.myProcessName() on Android 13 (#6720)
mrober 79deb5f
Fix bug that let responsePayloadBytes get set to -1 (#6721)
mrober 92632af
Update datastore dependency to 1.1.3 (#6688)
mrober 1aaa6cd
build(deps): bump org.eclipse.jgit:org.eclipse.jgit from 6.3.0.202209…
dependabot[bot] e12597e
build(deps): bump kotestAssertionsCore from 5.5.5 to 5.8.1 (#6736)
rlazo 4128d9a
Remove unnecessary steps in CI Testing for vertex (#6743)
rlazo a232b6d
Update functions changelog (#6751)
rlazo 123c9d7
[VertexAI] Add initial support to export covered API (#6749)
rlazo aa2bab8
Remove code style from deprecated message (#6753)
mrober af5fd66
Store registered context for sync task unregistrations (#6752)
welishr 7c03f49
Extend Firebase SDK with new APIs to consume streaming callable funct…
MustafaJadid2025 dfd0d7c
[Functions] Send the placeholder appcheck token in case of error (#6750)
rlazo 68f52ed
Read version control info from Android resource (#6754)
mrober 9340503
Use Dagger for dependency injection in Sessions (#6745)
mrober c9287ee
Add warning for known issue b/328687152 (#6755)
mrober d0fd4ca
m160 mergeback (#6757)
google-oss-bot 9f6cacb
[Vertex AI] Remove `golden-files` directory (#6740)
andrewheard 512251b
build(deps): bump app.cash.turbine:turbine from 1.0.0 to 1.2.0 (#6738)
dependabot[bot] 8f8a74d
Update changelogs and versions for Crashlytics, Perf, and AQS (#6758)
mrober bcdb963
build(deps): bump com.google.firebase:firebase-appdistribution-gradle…
dependabot[bot] 17c302e
Adjust Create Release (#6761)
emilypgoogle bdb330e
Add GenerationConfig to CountTokenRequest's (#6768)
rlazo 19dd95b
[VertexAI] Remove redundant tests (#6762)
rlazo b9be9f1
Add m161 changelog for functions (#6769)
emilypgoogle f7e98b8
dataconnect: demo: upgrade versions in build.gradle.kts (#6776)
dconeybe 1aca899
chore(functions): export reactive-streams as a transitive dependency …
thatfiredev 0554f0d
fix(functions): use notifyError() instead of throwing (#6773)
thatfiredev 9b42d84
fix for new version of golden files (#6771)
davidmotson 76990d9
build(deps): bump androidx.core:core from 1.2.0 to 1.15.0 (#6764)
dependabot[bot] f86d40d
Simplify settings package and a few more classes using DI (#6778)
mrober 236df1f
Setup kotlinx.serialization plugin (#6783)
mrober af1fe93
Swap external action to verify changed files for inline code (#6779)
rlazo 60a021d
[github actions] Pin actions to hash commits (#6784)
rlazo d0dc250
Add transform action to remove package prefix in toc files (#6787)
daymxn 49dd6e0
include the full googleid module in GenerateTutorialBundleTask.kt (#6…
thatfiredev 51a9b1d
ci: add missing permissions to .github/workflows/plugins-check.yml (#…
thatfiredev 2d5cabe
dataconnect: remove "beta" version marker and graduate the data conne…
dconeybe f9d1802
m161 mergeback (#6793)
google-oss-bot 615352d
[Functions] Several functions improvements (#6796)
rlazo 16aed70
[DataConnect] Update release configuration (#6798)
rlazo c1ca021
[DataConnect] Add changelog entry back (#6799)
rlazo e36a15b
dataconnect: DataConnectExecutableVersions.json updated with versions…
dconeybe 75be716
dataconnect: generateApiTxtFile.sh added (#6802)
dconeybe ba69975
feat: dataconnect: DataConnectOperationException added to support par…
dconeybe baa335c
Add fix for API info task (#6808)
emilypgoogle 1cf65b9
[VertexAI] Bump timeout for error test (#6807)
rlazo 564734a
[Vertex AI] Return `ImagenInlineImage.data` as binary (#6800)
andrewheard 8a72ed5
Add ML monitoring info to GenAI requests (#6804)
davidmotson f67d32d
[VertexAI] Log warning for unsupported model names (#6805)
rlazo 5ff9d95
Updated internal Crashpad version (#6797)
mrober dbeecd4
Add basic Vertex Java compilation tests (#6810)
emilypgoogle cf2b7a8
Upgrade to Android ndk r27c and update Crashpad to latest commit (#6814)
mrober 9da772e
Fix startup check failures (#6820)
daymxn e65e93f
[Functions] Bump all test timeouts to 10 seconds (#6821)
rlazo d2e72df
Bidirectional Streaming Android (#6759)
VinayGuthal 278e437
Changes in the Session Test App to verify behaviour with Fireperf #no…
tejasd 395e9dd
fix emulator listening to itself (#6823)
VinayGuthal 2cdac31
Update changelog file (#6825)
rlazo 3d41253
m162 mergeback (#6831)
google-oss-bot 75cdf96
dataconnect: QuerySubscriptionIntegrationTest.kt: fix flaky test usin…
dconeybe a0a02a7
dataconnect: github actions cache key fix (#6829)
dconeybe 8af38c9
dataconnect: fix flaky test that ensures deserialize() throws Illegal…
dconeybe 9a07498
dataconnect: dataconnect.yml: some minor improvements (#6838)
dconeybe f97833e
[encoders] Replace deprecated Kotlin Stdlib functions with recommende…
rlazo 6e3be78
use bytestream instead of bytearray (#6847)
VinayGuthal f826b40
dataconnect: fix two flaky tests due to their failure to wait for Fir…
dconeybe dbf5d01
dataconnect: auth code internal cleanup (#6836)
dconeybe 58b9da4
[fireci] Update fireci setup declaration (#6851)
rlazo 5081e7c
Disconnect from Remote Config real-time server when app is background…
tusharkhandelwal8 9e89b28
Add support for HarmBlockThreshold.OFF (#6843)
daymxn 210dc02
dataconnect: AuthIntegrationTest.kt: add missing import for FirebaseD…
dconeybe d7a56a1
upate release notes (#6837)
VinayGuthal a362e45
dataconnect: dataconnect.yml: add job to comment on an issue (#6858)
dconeybe 3b7e1e4
Adjust Metalava SemVer task (#6846)
emilypgoogle 70c8e89
Improve the integration test coverage for online vs offline compariso…
ehsannas cad26b9
[Perf] Cache attribute key validation regex (#6865)
rlazo edcea54
fix: remove null value inclusion from `whereNotEqualTo` and `whereNot…
milaGGL 33e989f
update javadocs (#6848)
VinayGuthal 4797eea
[plugins] Remove JavaPluginConvention from FirebaseJavaLibraryPlugin …
rlazo 9293eec
Add write permisison to VertexAI Response Checking task (#6869)
emilypgoogle 329760f
build(deps): bump com.google.android.play:integrity from 1.2.0 to 1.4…
dependabot[bot] 24b9dad
build(deps): bump requests from 2.31.0 to 2.32.2 in /ci/fireci (#6853)
dependabot[bot] 5aff679
[RC] Remove package declaration from testapp manifest (#6875)
rlazo 24fba9b
fix: Improve efficiency of online/offline composite index tests. (#6868)
ehsannas 47e37b5
Update LiveModelFutures to return LiveSessionFutures instead of LiveS…
VinayGuthal 40b7637
Refactor live bidi (#6870)
daymxn 19c8c7f
fix: avoid android.os.strictmode.UnbufferedIoViolation (resubmission …
gubatron fb6189c
[SmokeTests] Enable desugaring in smoke tests (#6884)
rlazo e98dd2c
build(deps): bump glide from 4.11.0 to 4.16.0 (#6767)
dependabot[bot] 51b4a1c
dataconnect: Improve usage of MutableStateFlow to improve readability…
dconeybe bd2cb5f
dataconnect: create python script to post comments about scheduled ru…
dconeybe fd65539
dataconnect: use firebase-tools to launch fdc emulator instead of lau…
dconeybe fda3351
Handle error when stream was cancelled prior to calling halfClose. (#…
tom-andersen 534cc53
FirebaseDataConnectImpl.kt: use MutableStateFlow to store state, rath…
dconeybe e9ef479
Enable multimodal response generation in android (#6901)
VinayGuthal d568e84
Refactor: Rename encodeBitmapToBase64Png to encodeBitmapToBase64Jpeg …
rlazo b0d8622
Pin protolite-well-known-types (#6908)
emilypgoogle 4fb4dfd
Migrate LiveContentResponse.Status to properties (#6906)
daymxn 12127e6
encodeBitmapToBase64Png -> encodeBitmapToBase64Jpeg (#6912)
davidmotson b4a2197
Exclude protolite well known types from version bump. (#6909)
daymxn 7cbb80b
Davidmotson.firebase ai (#6911)
davidmotson 7924813
[ai] Use .json for unary tests instead of .txt (#6916)
rlazo a6010b2
Add Firebase AI to BoM (#6920)
daymxn a879354
Add inlineDataParts helper property (#6922)
daymxn cbd9636
Add ResponseModality support to GenerationConfig (#6921)
daymxn 7b7e11e
Fix AI test timeout (#6917)
daymxn 2b23887
Align LiveSeverMessage related protos (#6910)
daymxn 2491ec2
m163 mergeback (#6913)
google-oss-bot 4b12b33
Add Java VertexAI bidi compile tests (#6903)
emilypgoogle 0a880cc
[Ai] Add workaround for invalid SafetyRating from the backend. (#6925)
rlazo f5ec0a6
fix more strict mode violation (#6937)
themiswang 24dd7c4
Fix AI builders for Java consumers (#6930)
emilypgoogle bbe3de1
[Ai] Fix test code to point to the right resource dir (#6932)
rlazo 525f293
[Ai] Update test response check to verify firebase-ai (#6926)
rlazo 4c29e0b
Add headers to be able to track bidi usage (#6939)
VinayGuthal 4c4c7c9
[Storage] Migrate from Robolectric.flushForegroundThreadScheduler to …
rlazo 88f50d5
dataconnect: include relevant logcat snippets in github actions logs …
dconeybe 548dc28
Fix NetworkOnMainThreadException for API levels below 26 (#6940)
tusharkhandelwal8 7b1855d
Prepare VertexAI SDK for release (#6941)
daymxn f4649cd
Update headers to track vertex ai/developer usage in kotlin (#6944)
VinayGuthal a996019
Update Crashlytics changelog (#6945)
mrober 78360ad
Add crashlytics-ndk changelog entry (#6946)
daymxn 2a17764
update headers in the correct location (#6948)
VinayGuthal eee76b4
Revert "Update headers to track vertex ai/developer usage in kotlin (…
daymxn 1e2e2c1
Add Firebase AI to recipe version generation (#6951)
daymxn 9f50104
[ai] Include missing dependency suffix to firebase-ai (#6954)
rlazo 24cc366
[action] Only include merge message on sdk changes (#6955)
rlazo f2257e4
dataconnect: update dependencies in demo app (#6952)
dconeybe 129cb89
Update changelog and Vertex version from M164 (#6970)
daymxn 331905b
m164 mergeback (#6973)
google-oss-bot 9c00477
fix(ai): pass FunctionDeclaration#description arg to internal class (…
thatfiredev 82ad185
Fix Firebase AI StackOverflow (#6972)
emilypgoogle 5db7bfb
Use correct name in release notes for vertexai (#6976)
rlazo 61d972c
build(deps): bump com.google.firebase:firebase-components from 18.0.0…
dependabot[bot] 9f5839f
Add macrobenchmark module for sessions test app (#6982)
mrober ec4b353
Migrate from Robolectric.flushForegroundThreadScheduler to ShadowLoop…
hoisie 4e027a9
Update ImagenPersonFilterLevel refdocs to match the iOS SDK (#6995)
thatfiredev 366095f
Add a NamedThreadFactory to WithinAppServiceConnection's Executor. (#…
gsakakihara af24598
update voice (#6996)
VinayGuthal b2fe881
dataconnect: Fixed occasional `NullPointerException` leading to erron…
dconeybe bfd3c76
dataconnect: DataConnectExecutableVersions.json updated with versions…
dconeybe f03fe1c
Add a flag to the Firebase Sessions test app for verbose Sessions (#7…
tejasd d4a3068
Davidmotson.google count token modelname (#7011)
davidmotson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
name: Data Connect Workflow Notifications | ||
description: Notify a GitHub Issue with the results of a workflow. | ||
|
||
inputs: | ||
python-version: | ||
required: true | ||
default: "3.13" | ||
github-issue-for-scheduled-runs: | ||
required: true | ||
job-results-file: | ||
required: true | ||
|
||
runs: | ||
using: "composite" | ||
steps: | ||
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0 | ||
with: | ||
python-version: ${{ inputs.python-version }} | ||
|
||
- run: pip install -r requirements.txt | ||
shell: bash | ||
working-directory: firebase-dataconnect/ci | ||
|
||
- id: issue-id | ||
name: Determine GitHub Issue For Commenting | ||
working-directory: firebase-dataconnect/ci | ||
shell: bash | ||
run: | | ||
args=( | ||
python | ||
calculate_github_issue_for_commenting.py | ||
--issue-output-file=github_issue_number.txt | ||
--github-repository='${{ github.repository }}' | ||
--github-ref='${{ github.ref }}' | ||
--github-event-name='${{ github.event_name }}' | ||
--pr-body-github-issue-key=trksmnkncd_notification_issue | ||
--github-issue-for-scheduled-run='${{ inputs.github-issue-for-scheduled-runs }}' | ||
) | ||
echo "${args[*]}" | ||
"${args[@]}" | ||
|
||
set -xv | ||
issue="$(cat github_issue_number.txt)" | ||
echo "issue=$issue" >> "$GITHUB_OUTPUT" | ||
|
||
- name: Post Comment on GitHub Issue | ||
if: steps.issue-id.outputs.issue != '' | ||
working-directory: firebase-dataconnect/ci | ||
shell: bash | ||
run: | | ||
args=( | ||
python | ||
post_comment_for_job_results.py | ||
--github-issue='${{ steps.issue-id.outputs.issue }}' | ||
--github-workflow='${{ github.workflow }}' | ||
--github-repository='${{ github.repository }}' | ||
--github-ref='${{ github.ref }}' | ||
--github-event-name='${{ github.event_name }}' | ||
--github-sha='${{ github.sha }}' | ||
--github-repository-html-url='${{ github.event.repository.html_url }}' | ||
--github-run-id='${{ github.run_id }}' | ||
--github-run-number='${{ github.run_number }}' | ||
--github-run-attempt='${{ github.run_attempt }}' | ||
) | ||
|
||
while read -r line; do | ||
args=("${args[@]}" "$line") | ||
done <'${{ inputs.job-results-file }}' | ||
|
||
echo "${args[*]}" | ||
exec "${args[@]}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 14 additions & 12 deletions
26
...ub/workflows/check-vertexai-responses.yml → .../workflows/check-firebaseai-responses.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +1,42 @@ | ||
name: Check Vertex AI Responses | ||
name: Check Firebase AI Responses | ||
|
||
on: pull_request | ||
|
||
jobs: | ||
check-version: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
pull-requests: write | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
- name: Clone mock responses | ||
run: firebase-vertexai/update_responses.sh | ||
run: firebase-ai/update_responses.sh | ||
- name: Find cloned and latest versions | ||
run: | | ||
CLONED=$(git describe --tags) | ||
LATEST=$(git tag --sort=v:refname | tail -n1) | ||
echo "cloned_tag=$CLONED" >> $GITHUB_ENV | ||
echo "latest_tag=$LATEST" >> $GITHUB_ENV | ||
working-directory: firebase-vertexai/src/test/resources/vertexai-sdk-test-data | ||
working-directory: firebase-ai/src/test/resources/vertexai-sdk-test-data | ||
- name: Find comment from previous run if exists | ||
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e | ||
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e # v3.1.0 | ||
id: fc | ||
with: | ||
issue-number: ${{github.event.number}} | ||
body-includes: Vertex AI Mock Responses Check | ||
body-includes: Firebase AI Mock Responses Check | ||
- name: Comment on PR if newer version is available | ||
if: ${{env.cloned_tag != env.latest_tag && !steps.fc.outputs.comment-id}} | ||
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 | ||
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0 | ||
with: | ||
issue-number: ${{github.event.number}} | ||
body: > | ||
### Vertex AI Mock Responses Check :warning: | ||
A newer major version of the mock responses for Vertex AI unit tests is available. | ||
[update_responses.sh](https://github.com/firebase/firebase-android-sdk/blob/main/firebase-vertexai/update_responses.sh) | ||
### Firebase AI Mock Responses Check :warning: | ||
|
||
A newer major version of the mock responses for Firebase AI unit tests is available. | ||
[update_responses.sh](https://github.com/firebase/firebase-android-sdk/blob/main/firebase-ai/update_responses.sh) | ||
should be updated to clone the latest version of the responses: `${{env.latest_tag}}` | ||
- name: Delete comment when version gets updated | ||
if: ${{env.cloned_tag == env.latest_tag && steps.fc.outputs.comment-id}} | ||
uses: detomarco/delete-comment@850734dd44d8b15fef55b45252613b903ceb06f0 | ||
uses: detomarco/delete-comment@dd37d1026c669ebfb0ffa5d23890010759ff05d5 # v1.1.0 | ||
with: | ||
comment-id: ${{ steps.fc.outputs.comment-id }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / Scorecard
Token-Permissions High