Propagate error for ListAll #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| apply from: '../../gradle/googleServices.gradle' | ||
|
|
||
| apply plugin: "com.google.gms.google-services" |
There was a problem hiding this comment.
I needed to add this line for the Test App to start. I hope it doesn't beak CI.
There was a problem hiding this comment.
I changed this to call initializeApp because it does break CI.
schmidt-sebastian
force-pushed
the
mrschmidt/listerror
branch
from
d707311 to
bd2e76a
Compare
|
@fredzqm Let me know if you feel comfortable reviewing this. |
fredzqm
approved these changes
Aug 16, 2019
| @@ -104,6 +105,7 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| super.onCreate(savedInstanceState); | |||
| setContentView(R.layout.activity_main); | |||
|
|
|||
| FirebaseApp.initializeApp(getApplicationContext()); | |||
There was a problem hiding this comment.
OOC, why this line weren't there before?
There was a problem hiding this comment.
This lets us use the test app without the Google Services plugin, which we had to remove as it breaks the CI build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that we didn't propagate backend errors for ListAll, instead the Task would just hang.
Fixes https://b.corp.google.com/issues/139533387