Skip to content

Fix issue with UTF8 strings in RC SDK 19.0.0 #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2019
Merged

Fix issue with UTF8 strings in RC SDK 19.0.0 #718

merged 3 commits into from
Aug 21, 2019

Conversation

clp93
Copy link
Contributor

@clp93 clp93 commented Aug 20, 2019 •
edited
Loading

UTF-8 characters are not being parsed correctly on fetches from the backend. Explicitly specifying the Character set resolves this issue.

Unit tests added as well to prevent a recurrence of this issue.

@googlebot googlebot added the cla: yes Override cla label Aug 20, 2019
@clp93 clp93 requested a review from miraziz August 20, 2019 17:59
@clp93 clp93 requested a review from ashwinraghav August 20, 2019 18:00
@clp93 clp93 requested review from SinanKadavath and kroikie August 20, 2019 18:54
@clp93 clp93 merged commit 88d909c into master Aug 21, 2019
@clp93 clp93 deleted the clp-utf8 branch August 21, 2019 16:39
@hnljp hnljp mentioned this pull request Sep 5, 2019
Closed
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kroikie kroikie kroikie approved these changes

@miraziz miraziz Awaiting requested review from miraziz

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

@SinanKadavath SinanKadavath Awaiting requested review from SinanKadavath

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clp93 @kroikie @googlebot @google-oss-bot