Skip to content

Update sdk versions. #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

Update sdk versions. #746

merged 1 commit into from
Aug 29, 2019

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 28, 2019

No description provided.

@rlazo rlazo requested review from vkryachko and VinayGuthal August 28, 2019 20:40
@googlebot googlebot added the cla: yes Override cla label Aug 28, 2019
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.terminate() [AddedMethod]
error: Added method com.google.firebase.firestore.FirebaseFirestore.waitForPendingWrites() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

@rlazo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
api-information be63a4c link /test api-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit c8544b1 into master Aug 29, 2019
@rlazo rlazo deleted the rl.update-versions branch August 29, 2019 02:04
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@VinayGuthal VinayGuthal VinayGuthal approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rlazo @google-oss-bot @vkryachko @VinayGuthal @googlebot