Random code cleanup for Storage #758
Conversation
|
The public api surface has changed for the subproject firebase-storage: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
| Log.e(TAG, "Unable to create a valid default Uri. " + bucket + path, e); | ||
| throw new IllegalStateException(e); | ||
| } | ||
| uri = |
There was a problem hiding this comment.
Inline variable declaration?
|
|
||
| throw new IllegalArgumentException("childName"); | ||
| } | ||
| child = |
| mPendingResult.setException(StorageException.fromException(e)); | ||
| return; | ||
| } | ||
| request = |
| mException = e; | ||
| return; | ||
| } | ||
| startRequest = |
|
Inlined all assignments. Thanks for reviewing! |
|
The public api surface has changed for the subproject firebase-storage: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
/test check-changed |
1 similar comment
|
/test check-changed |
|
/test check-changed |
getReference()helper in all Integration test.Uri.encode()since it doesn't throw exceptions (and follows the existing encoding of spaces to %20 everywhere)