Simplify IndexFree tests #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (MaybeDocument doc : docs) { | ||
| DocumentChange change = | ||
| new DocumentChange(updatedInTargets, removedFromTargets, doc.getKey(), doc); | ||
| aggregator.handleDocumentChange(change); | ||
| version = doc.getVersion().compareTo(version) > 0 ? doc.getVersion() : version; |
There was a problem hiding this comment.
Not sure why this worked before but testQueriesIncludeDocumentsFromOtherQueries() needs to use 20 as the snapshot version (from the last doc) in order to use a higher read time for the newly added doc.
schmidt-sebastian
added a commit
that referenced
this pull request
Sep 13, 2019
This reverts commit a011927.
schmidt-sebastian
added a commit
that referenced
this pull request
Sep 13, 2019
schmidt-sebastian
added a commit
that referenced
this pull request
Sep 13, 2019
This reverts commit a011927.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the newly added Index-Free tests in LocalStoreTests: