Skip to content

Fix an internal integration test failure. #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

Fix an internal integration test failure. #791

merged 1 commit into from
Sep 12, 2019

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 12, 2019

See b/140307854.

@googlebot googlebot added the cla: yes Override cla label Sep 12, 2019
schmidt-sebastian
schmidt-sebastian reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the old code didn't work? Is there an inherent race that we can't get around?

@wu-hui
Copy link
Contributor Author

wu-hui commented Sep 12, 2019

Can you explain why the old code didn't work? Is there an inherent race that we can't get around?

FirebaseApp.getInstance throws exception when the instance cannot be found for a given name, old code assumes it returns null in that case, which is false.

@schmidt-sebastian schmidt-sebastian removed their assignment Sep 12, 2019
@wu-hui wu-hui merged commit 8a7b33c into master Sep 12, 2019
@rlazo rlazo deleted the wuandy/FixG3TestForReal branch October 3, 2019 14:44
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees
No one assigned
Labels
api: firestore cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @schmidt-sebastian @googlebot @google-oss-bot