Add support for wildcards on the CustomClassMapper. #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomClassMapper can now handle GenericTypeIndicators with wildcards, instead of strictly requiring the type specified.
vkryachko
reviewed
Sep 12, 2019
| @@ -1763,6 +1763,15 @@ public void subclassingGenericTypeIndicatorIsAllowed() { | |||
| assertEquals("foo", bean.value); | |||
| } | |||
|
|
|||
| @Test | |||
| public void usingWildcardInGenericTypeIndicatorIsAllowed() { | |||
There was a problem hiding this comment.
Can you also add tests for:
- wildcard with lowerbound throws
- wildcard with multiple upperBounds uses the first one
| // that this array always has at least one element, since the unbounded wildcard <?> always | ||
| // has at least an upper bound of Object. | ||
| Type[] upperBounds = ((WildcardType) type).getUpperBounds(); | ||
| hardAssert(upperBounds.length > 0, "Unexpected type bounds on wildcard " + type); |
There was a problem hiding this comment.
The assert message doesn't seem to match what is being asserted. While this problem exists in the original implementation, we could still want to take a stab at improving it.
An additional fix from Firestore for handling TypeVariables.
|
@schmidt-sebastian Added entry to the changelog. PTAL |
vkryachko
approved these changes
Sep 13, 2019
schmidt-sebastian
approved these changes
Sep 13, 2019
|
/test new-smoke-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomClassMapper can now handle GenericTypeIndicators with wildcards, instead of strictly requiring the type specified.