Skip to content

Revert "Add logging for query mode (#776)" #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Revert "Add logging for query mode (#776)" #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions ...ase-firestore/src/main/java/com/google/firebase/firestore/local/IndexFreeQueryEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import com.google.firebase.firestore.model.DocumentKey;
import com.google.firebase.firestore.model.MaybeDocument;
import com.google.firebase.firestore.model.SnapshotVersion;
import com.google.firebase.firestore.util.Logger;
import java.util.Collections;
import java.util.Map;

Expand Down Expand Up @@ -52,8 +51,6 @@
* </ol>
*/
public class IndexFreeQueryEngine implements QueryEngine {
private static final String LOG_TAG = "IndexFreeQueryEngine";

private LocalDocumentsView localDocumentsView;

@Override
Expand Down Expand Up @@ -86,14 +83,6 @@ && needsRefill(previousResults, remoteKeys, queryData.getLastLimboFreeSnapshotVe
return executeFullCollectionScan(query);
}

if (Logger.isDebugEnabled()) {
Logger.debug(
LOG_TAG,
"Re-using previous result from %s to execute query: %s",
queryData.getLastLimboFreeSnapshotVersion().toString(),
query.toString());
}

// Retrieve all results for documents that were updated since the last limbo-document free
// remote snapshot.
ImmutableSortedMap<DocumentKey, Document> updatedResults =
Expand Down Expand Up @@ -172,9 +161,6 @@ public void handleDocumentChange(MaybeDocument oldDocument, MaybeDocument newDoc
}

private ImmutableSortedMap<DocumentKey, Document> executeFullCollectionScan(Query query) {
if (Logger.isDebugEnabled()) {
Logger.debug(LOG_TAG, "Using full collection scan to execute query: %s", query.toString());
}
return localDocumentsView.getDocumentsMatchingQuery(query, SnapshotVersion.NONE);
}
}