Skip to content

Remove Index-Free assert #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2019
Merged

Remove Index-Free assert #800

merged 2 commits into from
Sep 13, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

This PR removes the assert that causes a crash for one of our customers:

Caused by: java.lang.AssertionError: INTERNAL ASSERTION FAILED: Cannot add document to the RemoteDocumentCache with a read time of zero
        at com.google.firebase.firestore.g.b.a(com.google.firebase:firebase-firestore@@21.1.0:46)
        at com.google.firebase.firestore.g.b.a(com.google.firebase:firebase-firestore@@21.1.0:31)

This is the first step in fixing this issue. As a follow up, we have to fix the underlying root cause and clean up all affected data.

@googlebot googlebot added the cla: yes Override cla label Sep 13, 2019
wilhuff
wilhuff reviewed Sep 13, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. CHANGELOG?

@schmidt-sebastian
Copy link
Contributor Author

CL added. PTAL.

wilhuff
wilhuff approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian schmidt-sebastian removed their assignment Sep 13, 2019
@wilhuff wilhuff assigned schmidt-sebastian and unassigned wilhuff Sep 13, 2019
@schmidt-sebastian
Copy link
Contributor Author

/test check-changed

@schmidt-sebastian schmidt-sebastian merged commit 6418e58 into master Sep 13, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/revert-assert branch September 13, 2019 18:19
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmidt-sebastian @wilhuff @googlebot @google-oss-bot