Implement AAR size measurement. #805
Conversation
The new task `generateAarSizeMeasurements` generates either a table or a JSON report with the size, in bytes, of the release AAR generated by each subproject. It follows the same logic, and has the same flags, as `generateApkSizeMeasurements`.
| @@ -30,7 +30,7 @@ android { | |||
| defaultConfig { | |||
| applicationId 'com.google.apksize' | |||
| minSdkVersion project.targetSdkVersion | |||
| multiDexEnabled true | |||
| multiDexEnabled true | |||
There was a problem hiding this comment.
Should this be aligned with the other lines?
| @@ -0,0 +1,5 @@ | |||
| firebase-database-collection | |||
There was a problem hiding this comment.
@vkryachko can confirm, but I have the impression that these are not actual sdks, but more like helper code or backend, so I wouldn't like to include those in the report.
There was a problem hiding this comment.
It would still be beneficial to know their sizes, don't you think?
There was a problem hiding this comment.
You're right. I've talked about this with @yifanyang too and agreed that I can report all the numbers. I'll update the PR accordingly. Thanks!
Nested projects are now correctly supported, naming them including the parent project, like `firebase-functions:ktx` instead of `ktx`.
| * Generates size measurements after building the release aar's. | ||
| * | ||
| * <p>This task can run in two modes. The first mode, enabled when running the task with the | ||
| * {@code pull_request} flag set, is a dependency of {@linkUploadMeasurementsTask} and generates |
There was a problem hiding this comment.
Missing a space between @link and Upload?
| @@ -42,6 +42,15 @@ task generateApkSizeMeasurements(type: GenerateMeasurementsTask) { | |||
| reportFile = file("$buildDir/size-report.json") | |||
| } | |||
|
|
|||
| task generateAarSizeMeasurements(type: com.google.firebase.gradle.plugins.measurement.aarsize.GenerateMeasurementsTask) { | |||
There was a problem hiding this comment.
I'm not an expert of groovy. Does it support import aliases like python or typescript?
There was a problem hiding this comment.
I didn't know either, but it does. Fixed!
| @@ -25,7 +25,7 @@ apply from: "src/config/config.gradle" | |||
| apply from: "src/database/database.gradle" | |||
| apply from: "src/firestore/firestore.gradle" | |||
| apply from: "src/functions/functions.gradle" | |||
| apply from: "src/inappmessagingdisplay/inappmessaging-display.gradle" | |||
| // apply from: "src/inappmessagingdisplay/inappmessaging-display.gradle" | |||
There was a problem hiding this comment.
It is. I commented it out during testing. Fixed.
|
@rlazo: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The new task
generateAarSizeMeasurementsgenerates either a table or a JSON report with the size, in bytes, of the release AAR generated by each subproject. It follows the same logic, and has the same flags, asgenerateApkSizeMeasurements.