Skip to content

[Smoke-tests] Remove combined flavor. #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 14 additions & 24 deletions smoke-tests/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -52,40 +52,30 @@ android {
if (project.hasProperty("testBuildType")) {
testBuildType project.getProperty("testBuildType")
}

flavorDimensions "systemUnderTest"

// TODO(allisonbm92): Switch to the default flavor.
productFlavors {
combined {
dimension "systemUnderTest"
applicationId "com.google.firebase.testing.combined"
}
}

}

apply from: "configure.gradle"

dependencies {
// Common
// Firebase
implementation "com.google.firebase:firebase-analytics"
implementation "com.google.firebase:firebase-auth"
implementation "com.google.firebase:firebase-common"
implementation "com.google.firebase:firebase-database"
implementation "com.google.firebase:firebase-dynamic-links"
implementation "com.google.firebase:firebase-firestore"
implementation "com.google.firebase:firebase-functions"
implementation "com.google.firebase:firebase-inappmessaging"
implementation "com.google.firebase:firebase-config"
implementation "com.google.firebase:firebase-storage"

// Common utilities (application side)
implementation "androidx.test:rules:1.2.0"
implementation "androidx.test:runner:1.2.0"
implementation "com.google.firebase:firebase-common"
implementation "com.google.truth:truth:0.44"
implementation "junit:junit:4.12"

// All
combinedImplementation "com.google.firebase:firebase-analytics"
combinedImplementation "com.google.firebase:firebase-auth"
combinedImplementation "com.google.firebase:firebase-database"
combinedImplementation "com.google.firebase:firebase-dynamic-links"
combinedImplementation "com.google.firebase:firebase-firestore"
combinedImplementation "com.google.firebase:firebase-functions"
combinedImplementation "com.google.firebase:firebase-inappmessaging"
combinedImplementation "com.google.firebase:firebase-config"
combinedImplementation "com.google.firebase:firebase-storage"

// Common utilities (instrumentation side)
androidTestImplementation "androidx.test:core:1.2.0"
androidTestImplementation "androidx.test:runner:1.2.0"
androidTestImplementation "junit:junit:4.12"
Expand Down
1 change: 0 additions & 1 deletion smoke-tests/runner.config
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ smokeTest {
# flavors
## This option specifies the Android flavors of the test to build for testing.
## It may be omitted if there are no flavors.
flavors combined

# googleServices
## This option is the path to the Google Services file. If provided, the
Expand Down
17 changes: 0 additions & 17 deletions smoke-tests/src/combined/AndroidManifest.xml

This file was deleted.

11 changes: 11 additions & 0 deletions smoke-tests/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,15 @@

<uses-permission android:name="android.permission.INTERNET" />

<application>
<activity android:name="android.app.Activity">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>

<meta-data android:name="com.google.firebase.testing.classes"
android:value="com.google.firebase.testing.combined.AllTests" />
</application>
</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public void buildDynamicLink_UriContainsCorrectComponents() throws Exception {
assertThat(actual.getHost()).isEqualTo("example.page.link");
assertThat(query)
.asList()
.containsAtLeast("apn=com.google.firebase.testing.combined", "link=http://www.example.com");
.containsAtLeast("apn=com.google.firebase.testing", "link=http://www.example.com");
}

@Test
Expand Down