Fix: Moving a local object in a return statement prevents copy elision (#620)

ehsannas · web-flow · commit 2c5d663b040d · 2021-08-26T13:34:56.000-05:00
diff --git a/firestore/src/main/user_data_converter_main.cc b/firestore/src/main/user_data_converter_main.cc
@@ -320,7 +320,7 @@ nanopb::Message<google_firestore_v1_Value> UserDataConverter::ParseArray(
     result->array_value.values[i] = *parsed->release();
   }
 
-  return std::move(result);
+  return result;
 }
 
 Message<google_firestore_v1_Value> UserDataConverter::ParseMap(

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,7 @@ nanopb::Message<google_firestore_v1_Value> UserDataConverter::ParseArray(`
`320`	`320`	`result->array_value.values[i] = *parsed->release();`
`321`	`321`	`}`
`322`	`322`
`323`		`- return std::move(result);`
	`323`	`+ return result;`
`324`	`324`	`}`
`325`	`325`
`326`	`326`	`Message<google_firestore_v1_Value> UserDataConverter::ParseMap(`